eive/eive-obsw
eive/eive-obsw
13
4
Fork 0
Code Issues 4 Pull Requests 1 Releases 120 Wiki Activity

RW shutdown #580

Merged
muellerr merged 6 commits from feature_proper_rw_shutdown into develop 2023-04-07 17:20:31 +02:00
Conversation 2 Commits 6 Files Changed 8 +132 -104
muellerr commented 2023-04-07 11:37:43 +02:00
Owner
Copy Link
No description provided.
muellerr added 1 commit 2023-04-07 11:37:44 +02:00
that should do it
Some checks are pending
EIVE/eive-obsw/pipeline/head Build queued...
Details
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
d98873c9a6
muellerr added this to the v1.44.0 milestone 2023-04-07 11:37:47 +02:00
muellerr requested review from meggert 2023-04-07 11:37:51 +02:00
meggert approved these changes 2023-04-07 12:01:31 +02:00
meggert commented 2023-04-07 12:14:36 +02:00
Owner
Copy Link

we might want to change the safe mode sequence with this i. e. switching the RWs off after the ACS controller switched to safe

we might want to change the safe mode sequence with this i. e. switching the RWs off after the ACS controller switched to safe
meggert commented 2023-04-07 12:18:00 +02:00
Owner
Copy Link

now that I'm thinking about it, all off transitions should be after the ACS controller switch, so that it does not get confused about states of its actuators and sensors

now that I'm thinking about it, all off transitions should be after the ACS controller switch, so that it does not get confused about states of its actuators and sensors
muellerr added 2 commits 2023-04-07 17:04:25 +02:00
changelog
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
014ac8b8c2
muellerr changed title from WIP: RW shutdown to RW shutdown 2023-04-07 17:04:47 +02:00
muellerr added 1 commit 2023-04-07 17:10:30 +02:00
add some thread safety
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
353b9bd322
muellerr added 2 commits 2023-04-07 17:20:15 +02:00
remove obsolete code
Some checks are pending
EIVE/eive-obsw/pipeline/pr-develop Build started...
Details
ebcd0cdfa1
muellerr merged commit a419589a7f into develop 2023-04-07 17:20:31 +02:00
muellerr deleted branch feature_proper_rw_shutdown 2023-04-07 17:20:32 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
meggert
Labels
Clear labels   
OPS TODO

Issues identified by OPS

  
api change

API change

  
breaking api change

API change which can break existing code

  
bug

Something is not working

  
documentation

Documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
OPS TODO
api change
breaking api change
bug
documentation
duplicate
feature
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
v1.44.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: eive/eive-obsw#580
No description provided.
Delete Branch "feature_proper_rw_shutdown"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?