SUS Total Vector Eclipse Fix #684

Merged
muellerr merged 5 commits from sus-tot-reset-fix into main 2023-06-16 18:28:54 +02:00
Owner

The SUS Total Vector was not being reset to [0,0,0] during eclipse. This is however only a visual bug, due to it still being set invalid and therefore not being used.

The SUS Total Vector was not being reset to [0,0,0] during eclipse. This is however only a visual bug, due to it still being set invalid and therefore not being used.
meggert added the
bug
label 2023-06-15 18:07:02 +02:00
meggert added 2 commits 2023-06-15 18:07:04 +02:00
fixed memcpy
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
cada6e0440
changelog
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
EIVE/eive-obsw/pipeline/pr-main This commit looks good
51a3a2f5cf
meggert requested review from muellerr 2023-06-15 18:07:30 +02:00
meggert changed title from SUS Total Vector Eclipse Fix to WIP: SUS Total Vector Eclipse Fix 2023-06-15 18:09:53 +02:00
meggert added 1 commit 2023-06-15 18:16:15 +02:00
cleanup
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
3dbc01bd8a
meggert changed title from WIP: SUS Total Vector Eclipse Fix to SUS Total Vector Eclipse Fix 2023-06-15 18:38:51 +02:00
muellerr requested changes 2023-06-15 19:09:43 +02:00
@ -24,2 +24,4 @@
const AcsParameters *acsParameters); // Will call protected functions
private:
static constexpr float ZERO_VEC_F[3] = {0, 0, 0};
static constexpr float ZERO_VEC_D[3] = {0, 0, 0};
Owner

I guess this should be a double?

I guess this should be a double?
Author
Owner

fixed

fixed
muellerr added this to the v4.0.0 milestone 2023-06-15 19:18:10 +02:00
muellerr modified the milestone from v4.0.0 to v3.2.0 2023-06-15 19:18:37 +02:00
meggert added 1 commit 2023-06-15 20:07:24 +02:00
fixed type of doube zero vector
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
e130d45f0b
muellerr requested changes 2023-06-16 13:26:34 +02:00
@ -56,0 +50,4 @@
std::memcpy(mgmDataProcessed->mgm2vec.value, ZERO_VEC_F, 3 * sizeof(float));
std::memcpy(mgmDataProcessed->mgm3vec.value, ZERO_VEC_F, 3 * sizeof(float));
std::memcpy(mgmDataProcessed->mgm4vec.value, ZERO_VEC_F, 3 * sizeof(float));
std::memcpy(mgmDataProcessed->mgmVecTot.value, ZERO_VEC_D, 3 * sizeof(float));
Owner

3 * sizeof(float)

3 * sizeof(float)
Author
Owner

fixed

fixed
meggert added 1 commit 2023-06-16 14:21:44 +02:00
fixed sizeof for mgmVec stuff
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
df4205c71e
muellerr approved these changes 2023-06-16 18:28:44 +02:00
muellerr merged commit 86d22affe2 into main 2023-06-16 18:28:53 +02:00
muellerr deleted branch sus-tot-reset-fix 2023-06-16 18:28:54 +02:00
Sign in to join this conversation.
No description provided.