eive/eive-obsw
eive
/
eive-obsw
12
3
Fork 0
Code Issues 3 Pull Requests 1 Releases 117 Wiki Activity

SUS Total Vector Eclipse Fix #684

Merged
muellerr merged 5 commits from sus-tot-reset-fix into main 2023-06-16 18:28:54 +02:00
Conversation 0 Commits 5 Files Changed 3 +34 -33
meggert commented 2023-06-15 18:07:02 +02:00
Owner
Copy Link

The SUS Total Vector was not being reset to [0,0,0] during eclipse. This is however only a visual bug, due to it still being set invalid and therefore not being used.

The SUS Total Vector was not being reset to [0,0,0] during eclipse. This is however only a visual bug, due to it still being set invalid and therefore not being used.
meggert added the
bug
 label 2023-06-15 18:07:02 +02:00
meggert added 2 commits 2023-06-15 18:07:04 +02:00
EIVE/eive-obsw/pipeline/head This commit looks good Details
cada6e0440 fixed memcpy
EIVE/eive-obsw/pipeline/head This commit looks good Details
EIVE/eive-obsw/pipeline/pr-main This commit looks good Details
51a3a2f5cf changelog
meggert requested review from muellerr 2023-06-15 18:07:30 +02:00
meggert changed title from SUS Total Vector Eclipse Fix to WIP: SUS Total Vector Eclipse Fix 2023-06-15 18:09:53 +02:00
meggert added 1 commit 2023-06-15 18:16:15 +02:00
EIVE/eive-obsw/pipeline/pr-main This commit looks good Details
3dbc01bd8a cleanup
meggert changed title from WIP: SUS Total Vector Eclipse Fix to SUS Total Vector Eclipse Fix 2023-06-15 18:38:51 +02:00
muellerr requested changes 2023-06-15 19:09:43 +02:00
mission/controller/acs/SensorProcessing.h Outdated
@ -24,2 +24,4 @@
const AcsParameters *acsParameters); // Will call protected functions
private:
static constexpr float ZERO_VEC_F[3] = {0, 0, 0};
static constexpr float ZERO_VEC_D[3] = {0, 0, 0};
muellerr commented 2023-06-15 19:09:32 +02:00
Owner
Copy Link

I guess this should be a double?

I guess this should be a double?
meggert commented 2023-06-15 20:07:34 +02:00
Author
Owner
Copy Link

fixed

fixed
muellerr added this to the v4.0.0 milestone 2023-06-15 19:18:10 +02:00
muellerr modified the milestone from v4.0.0 to v3.2.0 2023-06-15 19:18:37 +02:00
meggert added 1 commit 2023-06-15 20:07:24 +02:00
EIVE/eive-obsw/pipeline/pr-main This commit looks good Details
e130d45f0b fixed type of doube zero vector
muellerr requested changes 2023-06-16 13:26:34 +02:00
mission/controller/acs/SensorProcessing.cpp Outdated
@ -56,0 +50,4 @@
std::memcpy(mgmDataProcessed->mgm2vec.value, ZERO_VEC_F, 3 * sizeof(float));
std::memcpy(mgmDataProcessed->mgm3vec.value, ZERO_VEC_F, 3 * sizeof(float));
std::memcpy(mgmDataProcessed->mgm4vec.value, ZERO_VEC_F, 3 * sizeof(float));
std::memcpy(mgmDataProcessed->mgmVecTot.value, ZERO_VEC_D, 3 * sizeof(float));
muellerr commented 2023-06-16 13:26:17 +02:00
Owner
Copy Link

3 * sizeof(float)

3 * sizeof(float)
meggert commented 2023-06-16 14:22:21 +02:00
Author
Owner
Copy Link

fixed

fixed
meggert added 1 commit 2023-06-16 14:21:44 +02:00
EIVE/eive-obsw/pipeline/pr-main This commit looks good Details
df4205c71e fixed sizeof for mgmVec stuff
muellerr approved these changes 2023-06-16 18:28:44 +02:00
muellerr merged commit 86d22affe2 into main 2023-06-16 18:28:53 +02:00
muellerr deleted branch sus-tot-reset-fix 2023-06-16 18:28:54 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
muellerr
Labels
Clear labels   
OPS TODO

Issues identified by OPS

  
api change

API change

  
breaking api change

API change which can break existing code

  
bug

Something is not working

  
documentation

Documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
OPS TODO
api change
breaking api change
bug
documentation
duplicate
feature
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
v3.2.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: eive/eive-obsw#684
No description provided.
Delete Branch "sus-tot-reset-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?