PDEC corrupted Config Event #773

Merged
muellerr merged 10 commits from meier/pdec-config-readback into main 2023-08-15 13:24:03 +02:00
Owner
  • added event which is triggered when the PDEC configuration does not match the expected configuration
  • parameter one of the event contains the readback of the first word and parameter two the readback of the second word
* added event which is triggered when the PDEC configuration does not match the expected configuration * parameter one of the event contains the readback of the first word and parameter two the readback of the second word
meierj added 1 commit 2023-08-07 17:12:45 +02:00
added event which is triggered when config of pdec is corrupted
Some checks are pending
EIVE/eive-obsw/pipeline/head Build started...
EIVE/eive-obsw/pipeline/pr-main This commit looks good
c3bca9bb54
meierj requested review from muellerr 2023-08-07 17:46:34 +02:00
meierj requested review from meggert 2023-08-07 17:46:41 +02:00
meierj changed title from WIP: PDEC corrupted Config Event to PDEC corrupted Config Event 2023-08-07 18:19:05 +02:00
meggert requested changes 2023-08-08 09:25:12 +02:00
@ -192,0 +179,4 @@
ReturnValue_t result =
localParameterHandler.getValue(pdecconfigdefs::paramkeys::POSITIVE_WINDOW, positiveWindow);
if (result != returnvalue::OK) {
return result;
Owner

This will return a returnvalue for an uint32_t function. This will also mean writeFrameHeaderFirstWord() will always return an returnvalue::OK, even if this function returns early. This function probably should always return a returnvalue and the word should be passed by pointer.

This will return a returnvalue for an uint32_t function. This will also mean `writeFrameHeaderFirstWord()` will always return an `returnvalue::OK`, even if this function returns early. This function probably should always return a returnvalue and the word should be passed by pointer.
Author
Owner

Good catch. Should be fixed now.

Good catch. Should be fixed now.
meggert marked this conversation as resolved
@ -192,0 +190,4 @@
ReturnValue_t result =
localParameterHandler.getValue(pdecconfigdefs::paramkeys::NEGATIVE_WINDOW, negativeWindow);
if (result != returnvalue::OK) {
return result;
Owner

same as above

same as above
meggert marked this conversation as resolved
meierj added 1 commit 2023-08-11 16:16:15 +02:00
config word functions pass value now by reference and return returnvalue
Some checks are pending
EIVE/eive-obsw/pipeline/pr-main This commit looks good
EIVE/eive-obsw/pipeline/head Build started...
d28ec2c31a
meierj changed title from PDEC corrupted Config Event to WIP: PDEC corrupted Config Event 2023-08-11 16:20:08 +02:00
muellerr added this to the v6.4.0 milestone 2023-08-14 10:41:59 +02:00
muellerr added 1 commit 2023-08-14 15:06:25 +02:00
auto-formatting
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
567d68107d
muellerr added 1 commit 2023-08-14 15:07:01 +02:00
Merge remote-tracking branch 'origin/main' into meier/pdec-config-readback
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
e2b54ddb8e
muellerr added 1 commit 2023-08-14 15:09:49 +02:00
changelog and re-run generators
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
424f3c5247
muellerr added 2 commits 2023-08-14 16:07:18 +02:00
bump tmtc
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
693c183dcc
muellerr added 1 commit 2023-08-15 10:50:03 +02:00
Merge remote-tracking branch 'origin/main' into meier/pdec-config-readback
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
bda57d9bd1
muellerr changed title from WIP: PDEC corrupted Config Event to PDEC corrupted Config Event 2023-08-15 11:06:25 +02:00
meggert approved these changes 2023-08-15 11:08:11 +02:00
muellerr added 1 commit 2023-08-15 13:21:54 +02:00
Merge remote-tracking branch 'origin/main' into meier/pdec-config-readback
Some checks are pending
EIVE/eive-obsw/pipeline/pr-main Build queued...
e24212207f
muellerr added 1 commit 2023-08-15 13:22:43 +02:00
Merge remote-tracking branch 'origin/main' into meier/pdec-config-readback
Some checks are pending
EIVE/eive-obsw/pipeline/pr-main Build queued...
63b483b71a
muellerr merged commit 77e3b8c359 into main 2023-08-15 13:24:03 +02:00
muellerr deleted branch meier/pdec-config-readback 2023-08-15 13:24:03 +02:00
Sign in to join this conversation.
No description provided.