PDEC corrupted Config Event #773

meierj · 2023-08-07T17:12:44+02:00

meierj commented

2023-08-07 17:12:44 +02:00

added event which is triggered when the PDEC configuration does not match the expected configuration
parameter one of the event contains the readback of the first word and parameter two the readback of the second word

* added event which is triggered when the PDEC configuration does not match the expected configuration * parameter one of the event contains the readback of the first word and parameter two the readback of the second word

meierj added 1 commit 2023-08-07 17:12:45 +02:00

EIVE/eive-obsw/pipeline/head Build started... Details

EIVE/eive-obsw/pipeline/pr-main This commit looks good Details

c3bca9bb54 added event which is triggered when config of pdec is corrupted

meierj requested review from muellerr 2023-08-07 17:46:34 +02:00

meierj requested review from meggert 2023-08-07 17:46:41 +02:00

meierj changed title from ~~WIP: PDEC corrupted Config Event~~ to PDEC corrupted Config Event

2023-08-07 18:19:05 +02:00

meggert requested changes 2023-08-08 09:25:12 +02:00

linux/ipcore/PdecConfig.cpp Outdated

						
				@ -192,0 +179,4 @@

					ReturnValue_t result =

							localParameterHandler.getValue(pdecconfigdefs::paramkeys::POSITIVE_WINDOW, positiveWindow);

					if (result != returnvalue::OK) {

						return result;

meggert commented

2023-08-08 09:23:01 +02:00

This will return a returnvalue for an uint32_t function. This will also mean writeFrameHeaderFirstWord() will always return an returnvalue::OK, even if this function returns early. This function probably should always return a returnvalue and the word should be passed by pointer.

This will return a returnvalue for an uint32_t function. This will also mean `writeFrameHeaderFirstWord()` will always return an `returnvalue::OK`, even if this function returns early. This function probably should always return a returnvalue and the word should be passed by pointer.

meierj commented

2023-08-11 16:19:54 +02:00

Good catch. Should be fixed now.

meggert marked this conversation as resolved

linux/ipcore/PdecConfig.cpp Outdated

						
				@ -192,0 +190,4 @@

					ReturnValue_t result =

							localParameterHandler.getValue(pdecconfigdefs::paramkeys::NEGATIVE_WINDOW, negativeWindow);

					if (result != returnvalue::OK) {

						return result;