eive/eive-obsw
eive
/
eive-obsw
12
3
Fork 0
Code Issues 3 Pull Requests 1 Releases 116 Wiki Activity

Add CCSDS handler modes #352

Merged
muellerr merged 6 commits from add_ccsds_handler_modes into develop 2023-01-26 17:04:09 +01:00
Conversation 0 Commits 6 Files Changed 5 +89 -7
muellerr commented 2023-01-24 19:08:02 +01:00
Owner
Copy Link
No description provided.
muellerr added 1 commit 2023-01-24 19:08:04 +01:00
EIVE/eive-obsw/pipeline/head Build queued... Details
EIVE/eive-obsw/pipeline/pr-develop This commit looks good Details
8f8416c078
add modes
muellerr requested review from meierj 2023-01-24 19:08:12 +01:00
muellerr requested review from mkranz 2023-01-24 19:08:17 +01:00
muellerr added this to the v1.21.0 milestone 2023-01-24 19:08:21 +01:00
muellerr changed title from add modes to WIP: add modes 2023-01-24 19:08:28 +01:00
muellerr changed title from WIP: add modes to WIP: add CCSDS handler modes 2023-01-24 19:09:48 +01:00
muellerr added 1 commit 2023-01-24 19:47:26 +01:00
EIVE/eive-obsw/pipeline/pr-develop This commit looks good Details
ce12293dcc
update changelog
meierj reviewed 2023-01-25 11:06:37 +01:00
mission/tmtc/CcsdsIpCoreHandler.cpp Outdated
@ -342,0 +378,4 @@
mode = HasModesIF::MODE_ON;
}
} else if (submode == static_cast<Submode_t>(Submode::DATARATE_LOW)) {
ReturnValue_t result = ptmeConfig->setRate(RATE_500KBPS);
meierj commented 2023-01-25 11:06:37 +01:00
Owner
Copy Link

I think the rate should be set to 100 kbps here

I think the rate should be set to 100 kbps here
muellerr commented 2023-01-25 11:18:24 +01:00
Author
Owner
Copy Link

good spot

good spot
muellerr marked this conversation as resolved
meierj reviewed 2023-01-25 11:21:12 +01:00
mission/tmtc/CcsdsIpCoreHandler.h Outdated
@ -126,6 +138,9 @@ class CcsdsIpCoreHandler : public SystemObject,
ParameterHelper parameterHelper;
ActionHelper actionHelper;
Mode_t mode;
meierj commented 2023-01-25 11:21:12 +01:00
Owner
Copy Link

I think mode should be initialized somewhere. Either here or in the constructor

I think mode should be initialized somewhere. Either here or in the constructor
muellerr commented 2023-01-25 14:02:24 +01:00
Author
Owner
Copy Link

good spot 2. must have overlooked the warning..

good spot 2. must have overlooked the warning..
muellerr marked this conversation as resolved
muellerr added 1 commit 2023-01-25 14:02:11 +01:00
muellerr added 1 commit 2023-01-25 14:03:47 +01:00
EIVE/eive-obsw/pipeline/pr-develop This commit looks good Details
eef84f4d09
fixes from PR
muellerr added 1 commit 2023-01-26 12:04:59 +01:00
EIVE/eive-obsw/pipeline/pr-develop This commit looks good Details
1128d355bb
added some missing mode helper usage
muellerr changed title from WIP: add CCSDS handler modes to Add CCSDS handler modes 2023-01-26 12:07:36 +01:00
muellerr added 1 commit 2023-01-26 12:22:34 +01:00
EIVE/eive-obsw/pipeline/pr-develop This commit looks good Details
EIVE/eive-obsw/pipeline/head Build queued... Details
4deee6b98f Merge branch 'develop' into add_ccsds_handler_modes
muellerr merged commit ecc5ec05f3 into develop 2023-01-26 17:04:09 +01:00
muellerr deleted branch add_ccsds_handler_modes 2023-01-26 17:04:15 +01:00
meierj approved these changes 2023-01-30 08:52:26 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
mkranz
meierj
Labels
Clear labels   
OPS TODO

Issues identified by OPS

  
api change

API change

  
breaking api change

API change which can break existing code

  
bug

Something is not working

  
documentation

Documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
OPS TODO
api change
breaking api change
bug
documentation
duplicate
feature
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
v1.21.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: eive/eive-obsw#352
No description provided.
Delete Branch "add_ccsds_handler_modes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?