eive/eive-obsw
eive/eive-obsw
13
4
Fork 0
Code Issues 4 Pull Requests 1 Releases 120 Wiki Activity

Add CCSDS handler modes #352

Merged
muellerr merged 6 commits from add_ccsds_handler_modes into develop 2023-01-26 17:04:09 +01:00
Conversation 3 Commits 6 Files Changed 5 +2 -2
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit eef84f4d09 - Show all commits

2
mission/tmtc/CcsdsIpCoreHandler.cpp
View File

@ -378,7 +378,7 @@ void CcsdsIpCoreHandler::startTransition(Mode_t mode, Submode_t submode) {
mode = HasModesIF::MODE_ON; mode = HasModesIF::MODE_ON;
} }
} else if (submode == static_cast<Submode_t>(Submode::DATARATE_LOW)) { } else if (submode == static_cast<Submode_t>(Submode::DATARATE_LOW)) {
ReturnValue_t result = ptmeConfig->setRate(RATE_500KBPS); ReturnValue_t result = ptmeConfig->setRate(RATE_100KBPS);
muellerr marked this conversation as resolved Outdated
meierj commented 2023-01-25 11:06:37 +01:00
Outdated
Review
Copy Link

I think the rate should be set to 100 kbps here

I think the rate should be set to 100 kbps here
muellerr commented 2023-01-25 11:18:24 +01:00
Outdated
Review
Copy Link

good spot

good spot
if (result == returnvalue::OK) { if (result == returnvalue::OK) {
mode = HasModesIF::MODE_ON; mode = HasModesIF::MODE_ON;
} }

2
mission/tmtc/CcsdsIpCoreHandler.h
View File

@ -138,7 +138,7 @@ class CcsdsIpCoreHandler : public SystemObject,
ParameterHelper parameterHelper; ParameterHelper parameterHelper;
ActionHelper actionHelper; ActionHelper actionHelper;
Mode_t mode; Mode_t mode = HasModesIF::MODE_OFF;
muellerr marked this conversation as resolved Outdated
meierj commented 2023-01-25 11:21:12 +01:00
Outdated
Review
Copy Link

I think mode should be initialized somewhere. Either here or in the constructor

I think mode should be initialized somewhere. Either here or in the constructor
muellerr commented 2023-01-25 14:02:24 +01:00
Outdated
Review
Copy Link

good spot 2. must have overlooked the warning..

good spot 2. must have overlooked the warning..
Submode_t submode = static_cast<Submode_t>(Submode::UNSET); Submode_t submode = static_cast<Submode_t>(Submode::UNSET);
ModeHelper modeHelper; ModeHelper modeHelper;