eive/eive-obsw
eive/eive-obsw
12
3
Fork 0
Code Issues 4 Pull Requests 2 Releases 119 Wiki Activity

TCS continued #576

Merged
muellerr merged 19 commits from continue_tcs_tests into develop 2023-04-13 18:10:35 +02:00
Conversation 0 Commits 19 Files Changed 17 +295 -167
muellerr commented 2023-04-06 15:22:52 +02:00
Owner
Copy Link
No description provided.
muellerr added 9 commits 2023-04-06 15:22:54 +02:00
changelog
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
44325ee176
better handling for TCS ctrl state
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
19006e79b1
all heaters off wrapper
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
3a236a1a3b
i think thats an important bugfix
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
64b4db98ba
changelog
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
c5e18957f5
add some more cold test cases
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
7a53ada4b4
some tweaks and fixes
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
086dbcc19e
consecutive cold test
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
EIVE/eive-obsw/pipeline/pr-develop There was a failure building this commit
Details
d7dc3f34c7
muellerr added 1 commit 2023-04-06 15:31:27 +02:00
fix unittest
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
4acf66a020
muellerr added this to the v1.44.0 milestone 2023-04-06 17:50:43 +02:00
muellerr added 1 commit 2023-04-06 17:50:51 +02:00
Merge branch 'develop' into continue_tcs_tests
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
6156cc0b88
muellerr added 1 commit 2023-04-06 19:17:49 +02:00
Merge remote-tracking branch 'origin/develop' into continue_tcs_tests
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
5243f304af
muellerr added 1 commit 2023-04-07 11:07:18 +02:00
Merge branch 'develop' into continue_tcs_tests
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
aacd4dc088
muellerr modified the milestone from v1.44.0 to v1.45.0 2023-04-08 15:54:36 +02:00
muellerr added 1 commit 2023-04-08 15:56:57 +02:00
Merge remote-tracking branch 'origin/develop' into continue_tcs_tests
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
ece053e5c3
muellerr added 1 commit 2023-04-11 16:14:44 +02:00
Merge remote-tracking branch 'origin/develop' into continue_tcs_tests
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
8d9755c17f
muellerr added 1 commit 2023-04-12 10:53:45 +02:00
Merge remote-tracking branch 'origin/develop' into continue_tcs_tests
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
98d1da428a
muellerr added 1 commit 2023-04-12 13:00:56 +02:00
Merge remote-tracking branch 'origin/develop' into continue_tcs_tests
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
d9e38d97ee
muellerr requested review from meggert 2023-04-12 13:01:26 +02:00
meggert reviewed 2023-04-12 15:26:29 +02:00
mission/system/tree/tcsModeTree.cpp
@ -112,3 +112,3 @@
// Transition 1
iht(objects::THERMAL_CONTROLLER, NML, 0, TCS_TABLE_NORMAL_TRANS_1.second);
iht(objects::THERMAL_CONTROLLER, HasModesIF::MODE_ON, 0, TCS_TABLE_NORMAL_TRANS_1.second);
meggert commented 2023-04-12 15:26:22 +02:00
Owner
Copy Link

why ist the ctrl in on while the system is in normal?

why ist the ctrl in on while the system is in normal?
muellerr commented 2023-04-12 17:41:44 +02:00
Author
Owner
Copy Link

the ctrl only has/needs off and on

the ctrl only has/needs off and on
muellerr commented 2023-04-12 17:43:05 +02:00
Author
Owner
Copy Link

maybe we could reduce TCS subsystem to only include ON/OFF mode as well if this is not already the case.

maybe we could reduce TCS subsystem to only include ON/OFF mode as well if this is not already the case.
meggert commented 2023-04-12 17:46:39 +02:00
Owner
Copy Link

imo for the FSFW only OFF and NORMAL would make more sense but it is whatever

imo for the FSFW only OFF and NORMAL would make more sense but it is whatever
muellerr commented 2023-04-12 17:48:07 +02:00
Author
Owner
Copy Link

Hmm one could argue that normal is a superset of on with additional properties like periodic communication which are not relevant for a controller

Hmm one could argue that normal is a superset of on with additional properties like periodic communication which are not relevant for a controller
meggert commented 2023-04-12 17:51:52 +02:00
Owner
Copy Link

well your controller does command stuff so it does communicate in a way. a ctrl in ON would be a controller which calculates its commands but doesn't execute them to me. anyways it is not really relevant for the functionality here

well your controller does command stuff so it does communicate in a way. a ctrl in ON would be a controller which calculates its commands but doesn't execute them to me. anyways it is not really relevant for the functionality here
meggert approved these changes 2023-04-12 17:46:47 +02:00
muellerr added 1 commit 2023-04-12 18:07:44 +02:00
Merge branch 'develop' into continue_tcs_tests
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
94431cfdb8
muellerr added 1 commit 2023-04-13 18:10:27 +02:00
Merge branch 'develop' into continue_tcs_tests
Some checks are pending
EIVE/eive-obsw/pipeline/pr-develop Build queued...
Details
f14677ec4e
muellerr merged commit b5f4b6cf7b into develop 2023-04-13 18:10:35 +02:00
muellerr deleted branch continue_tcs_tests 2023-04-13 18:10:36 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
meggert
Labels
Clear labels   
OPS TODO

Issues identified by OPS

  
api change

API change

  
breaking api change

API change which can break existing code

  
bug

Something is not working

  
documentation

Documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
OPS TODO
api change
breaking api change
bug
documentation
duplicate
feature
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
v1.45.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: eive/eive-obsw#576
No description provided.
Delete Branch "continue_tcs_tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?