eive/eive-obsw
eive/eive-obsw
13
4
Fork 0
Code Issues 4 Pull Requests 1 Releases 120 Wiki Activity

Custom OBSW update path #582

Merged
muellerr merged 6 commits from feature_custom_obsw_update_path into develop 2023-04-11 16:12:43 +02:00
Conversation 1 Commits 6 Files Changed 2 +19 -1
muellerr commented 2023-04-08 11:46:09 +02:00
Owner
Copy Link
No description provided.
muellerr added 2 commits 2023-04-08 11:46:11 +02:00
allow custom filename
Some checks are pending
EIVE/eive-obsw/pipeline/head Build started...
Details
a81b24b67f
changelog and tmtc bump
Some checks are pending
EIVE/eive-obsw/pipeline/head Build started...
Details
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
584b6e3038
muellerr requested review from mkranz 2023-04-08 11:46:18 +02:00
muellerr added this to the v1.44.0 milestone 2023-04-08 15:52:39 +02:00
muellerr modified the milestone from v1.44.0 to v1.45.0 2023-04-08 15:54:18 +02:00
muellerr added 1 commit 2023-04-08 15:56:00 +02:00
Merge remote-tracking branch 'origin/develop' into feature_custom_obsw_update_path
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
1c0fbace4d
muellerr removed review request for mkranz 2023-04-08 17:50:28 +02:00
mkranz was assigned by muellerr 2023-04-08 17:50:33 +02:00
muellerr requested review from meggert 2023-04-08 17:51:43 +02:00
meggert requested changes 2023-04-11 09:22:23 +02:00
bsp_q7s/core/CoreController.cpp Outdated
@ -2013,2 +2020,4 @@
cmd.clear();
// Remove the extracted files to keep directories clean.
std::filesystem::remove(strippedImagePath);
meggert commented 2023-04-11 09:16:47 +02:00
Owner
Copy Link

use bool remove( const std::filesystem::path& p, std::error_code& ec ) noexcept; instead

use `bool remove( const std::filesystem::path& p, std::error_code& ec ) noexcept;` instead
bsp_q7s/core/CoreController.cpp Outdated
@ -2014,1 +2021,4 @@
// Remove the extracted files to keep directories clean.
std::filesystem::remove(strippedImagePath);
std::filesystem::remove(obswVersionFilePath);
meggert commented 2023-04-11 09:17:12 +02:00
Owner
Copy Link

use bool remove( const std::filesystem::path& p, std::error_code& ec ) noexcept; instead

use `bool remove( const std::filesystem::path& p, std::error_code& ec ) noexcept;` instead
muellerr added 1 commit 2023-04-11 15:23:35 +02:00
use exceptionless API
Some checks failed
EIVE/eive-obsw/pipeline/pr-develop There was a failure building this commit
Details
af9f346698
muellerr added 1 commit 2023-04-11 15:26:26 +02:00
remove re-declaration
All checks were successful
EIVE/eive-obsw/pipeline/pr-develop This commit looks good
Details
af1d0759e1
muellerr added 1 commit 2023-04-11 16:12:31 +02:00
Merge branch 'develop' into feature_custom_obsw_update_path
Some checks are pending
EIVE/eive-obsw/pipeline/pr-develop Build queued...
Details
52620f3dda
muellerr merged commit d552b51c0d into develop 2023-04-11 16:12:43 +02:00
muellerr deleted branch feature_custom_obsw_update_path 2023-04-11 16:12:44 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
meggert
Labels
Clear labels
OPS TODO
Issues identified by OPS
api change
API change
breaking api change
API change which can break existing code
bug
Something is not working
documentation
Documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone v1.45.0
Assignees
Clear assignees
No Assignees mkranz
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: eive/eive-obsw#582
No description provided.
Delete Branch "feature_custom_obsw_update_path"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?