eive/eive-obsw
eive/eive-obsw
13
4
Fork 0
Code Issues 4 Pull Requests 1 Releases 120 Wiki Activity

Tweak for TM stores #650

Merged
meggert merged 3 commits from another-tweak-for-tm-stores into v2.1.0-dev 2023-05-25 10:21:20 +02:00
Conversation 2 Commits 3 Files Changed 4 +15 -17
muellerr commented 2023-05-25 08:48:21 +02:00
Owner
Copy Link
No description provided.
muellerr added 3 commits 2023-05-25 08:48:23 +02:00
changelog
Some checks are pending
EIVE/eive-obsw/pipeline/head Build started...
Details
8d041c6753
another small logic fix
Some checks are pending
EIVE/eive-obsw/pipeline/head Build queued...
Details
EIVE/eive-obsw/pipeline/pr-v2.1.0-dev This commit looks good
Details
e1aff4c641
muellerr added this to the v3.0.0 milestone 2023-05-25 08:48:28 +02:00
muellerr requested review from meggert 2023-05-25 08:48:32 +02:00
meggert reviewed 2023-05-25 09:35:10 +02:00
mission/com/TmStoreTaskBase.cpp
@ -137,3 +135,4 @@
// This can happen if a file is corrupted and the next file swap completes the dump.
dumpDoneHandler();
return returnvalue::OK;
} else if (result != returnvalue::OK) {
meggert commented 2023-05-25 09:34:42 +02:00
Owner
Copy Link

not that it matters, but shouldnt this be result != PersistentTmStor::DUMP_DONE

not that it matters, but shouldnt this be result != PersistentTmStor::DUMP_DONE
muellerr commented 2023-05-25 10:07:01 +02:00
Author
Owner
Copy Link

intended here

intended here
meggert marked this conversation as resolved
meggert approved these changes 2023-05-25 10:20:56 +02:00
meggert merged commit d22f948af4 into v2.1.0-dev 2023-05-25 10:21:20 +02:00
meggert deleted branch another-tweak-for-tm-stores 2023-05-25 10:21:21 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
meggert
Labels
Clear labels
OPS TODO
Issues identified by OPS
api change
API change
breaking api change
API change which can break existing code
bug
Something is not working
documentation
Documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone v3.0.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: eive/eive-obsw#650
No description provided.
Delete Branch "another-tweak-for-tm-stores"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?