eive/eive-obsw
eive
/
eive-obsw
12
3
Fork 0
Code Issues 3 Pull Requests 1 Releases 117 Wiki Activity

EIVE system changes for reboot handling #763

Merged
muellerr merged 7 commits from pdec-reboot-target-self-image into main 2023-08-02 09:27:27 +02:00
Conversation 1 Commits 7 Files Changed 3 +57 -10
muellerr commented 2023-08-01 09:30:05 +02:00
Owner
Copy Link
No description provided.
muellerr added 2 commits 2023-08-01 09:30:06 +02:00
EIVE/eive-obsw/pipeline/head Build started... Details
a884176773
improvements for reboot FDIR
EIVE/eive-obsw/pipeline/head Build queued... Details
EIVE/eive-obsw/pipeline/pr-main This commit looks good Details
b27694321f
update changelog
muellerr requested review from meggert 2023-08-01 09:35:41 +02:00
muellerr added this to the v6.3.0 milestone 2023-08-01 09:35:44 +02:00
muellerr added 1 commit 2023-08-01 09:36:18 +02:00
EIVE/eive-obsw/pipeline/pr-main This commit looks good Details
8105e5f689
more robust code
meggert requested changes 2023-08-01 13:23:27 +02:00
meggert left a comment
Owner
Copy Link

does work but execution is not clean

DEBUG | 11:16:38.842 | EventManager: PDEC_HANDLER reported event with ID 12410
DEBUG | 11:16:38.842 | PDEC_TRYING_RESET_WITH_INIT | P1 Hex: 0x0 | P1 Dec: 0 | P2 Hex: 0x0 | P2 Dec: 0
DEBUG | 11:16:48.842 | EventManager: EIVE_SYSTEM reported event with ID 14012
DEBUG | 11:16:48.842 | PDEC_REBOOT | P1 Hex: 0x0 | P1 Dec: 0 | P2 Hex: 0x0 | P2 Dec: 0
DEBUG | 11:16:49.242 | EventManager: EIVE_SYSTEM reported event with ID 14012
DEBUG | 11:16:49.242 | PDEC_REBOOT | P1 Hex: 0x0 | P1 Dec: 0 | P2 Hex: 0x0 | P2 Dec: 0
INFO | 11:16:49.462 | CoreController::actionPerformReboot: Rebooting on current image
DEBUG | 11:16:49.842 | EventManager: EIVE_SYSTEM reported event with ID 14012
DEBUG | 11:16:49.842 | PDEC_REBOOT | P1 Hex: 0x0 | P1 Dec: 0 | P2 Hex: 0x0 | P2 Dec: 0
DEBUG | 11:16:50.242 | EventManager: EIVE_SYSTEM reported event with ID 14012
DEBUG | 11:16:50.242 | PDEC_REBOOT | P1 Hex: 0x0 | P1 Dec: 0 | P2 Hex: 0x0 | P2 Dec: 0
DEBUG | 11:16:50.842 | EventManager: EIVE_SYSTEM reported event with ID 14012
DEBUG | 11:16:50.843 | PDEC_REBOOT | P1 Hex: 0x0 | P1 Dec: 0 | P2 Hex: 0x0 | P2 Dec: 0
DEBUG | 11:16:51.242 | EventManager: EIVE_SYSTEM reported event with ID 14012
DEBUG | 11:16:51.242 | PDEC_REBOOT | P1 Hex: 0x0 | P1 Dec: 0 | P2 Hex: 0x0 | P2 Dec: 0
DEBUG | 11:16:51.842 | EventManager: EIVE_SYSTEM reported event with ID 14012
DEBUG | 11:16:51.842 | PDEC_REBOOT | P1 Hex: 0x0 | P1 Dec: 0 | P2 Hex: 0x0 | P2 Dec: 0
ERROR | 11:16:52.165 | Sending a reboot command has failed
DEBUG | 11:16:52.165 | InternalErrorReporter::performOperation: Errors occured: Queue | TM | Store : 1 | 0 | 0
DEBUG | 11:16:52.242 | EventManager: EIVE_SYSTEM reported event with ID 14012
DEBUG | 11:16:52.242 | PDEC_REBOOT | P1 Hex: 0x0 | P1 Dec: 0 | P2 Hex: 0x0 | P2 Dec: 0
ERROR | 11:16:52.666 | Sending a reboot command has failed
DEBUG | 11:16:52.666 | InternalErrorReporter::performOperation: Errors occured: Queue | TM | Store : 1 | 0 | 0
INFO | 11:16:52.766 | Executing command: writeprotect 1 1 1
Can't lock already locked copy
Could not writeprotect chip 1, copy 1 lock 1
INFO | 11:16:52.827 | Graceful shutdown handling done
DEBUG | 11:16:52.842 | EventManager: EIVE_SYSTEM reported event with ID 14012
DEBUG | 11:16:52.842 | PDEC_REBOOT | P1 Hex: 0x0 | P1 Dec: 0 | P2 Hex: 0x0 | P2 Dec: 0
re-booting in 3ERROR | 11:16:53.166 | Sending a reboot command has failed
does work but execution is not clean ``` DEBUG | 11:16:38.842 | EventManager: PDEC_HANDLER reported event with ID 12410 DEBUG | 11:16:38.842 | PDEC_TRYING_RESET_WITH_INIT | P1 Hex: 0x0 | P1 Dec: 0 | P2 Hex: 0x0 | P2 Dec: 0 DEBUG | 11:16:48.842 | EventManager: EIVE_SYSTEM reported event with ID 14012 DEBUG | 11:16:48.842 | PDEC_REBOOT | P1 Hex: 0x0 | P1 Dec: 0 | P2 Hex: 0x0 | P2 Dec: 0 DEBUG | 11:16:49.242 | EventManager: EIVE_SYSTEM reported event with ID 14012 DEBUG | 11:16:49.242 | PDEC_REBOOT | P1 Hex: 0x0 | P1 Dec: 0 | P2 Hex: 0x0 | P2 Dec: 0 INFO | 11:16:49.462 | CoreController::actionPerformReboot: Rebooting on current image DEBUG | 11:16:49.842 | EventManager: EIVE_SYSTEM reported event with ID 14012 DEBUG | 11:16:49.842 | PDEC_REBOOT | P1 Hex: 0x0 | P1 Dec: 0 | P2 Hex: 0x0 | P2 Dec: 0 DEBUG | 11:16:50.242 | EventManager: EIVE_SYSTEM reported event with ID 14012 DEBUG | 11:16:50.242 | PDEC_REBOOT | P1 Hex: 0x0 | P1 Dec: 0 | P2 Hex: 0x0 | P2 Dec: 0 DEBUG | 11:16:50.842 | EventManager: EIVE_SYSTEM reported event with ID 14012 DEBUG | 11:16:50.843 | PDEC_REBOOT | P1 Hex: 0x0 | P1 Dec: 0 | P2 Hex: 0x0 | P2 Dec: 0 DEBUG | 11:16:51.242 | EventManager: EIVE_SYSTEM reported event with ID 14012 DEBUG | 11:16:51.242 | PDEC_REBOOT | P1 Hex: 0x0 | P1 Dec: 0 | P2 Hex: 0x0 | P2 Dec: 0 DEBUG | 11:16:51.842 | EventManager: EIVE_SYSTEM reported event with ID 14012 DEBUG | 11:16:51.842 | PDEC_REBOOT | P1 Hex: 0x0 | P1 Dec: 0 | P2 Hex: 0x0 | P2 Dec: 0 ERROR | 11:16:52.165 | Sending a reboot command has failed DEBUG | 11:16:52.165 | InternalErrorReporter::performOperation: Errors occured: Queue | TM | Store : 1 | 0 | 0 DEBUG | 11:16:52.242 | EventManager: EIVE_SYSTEM reported event with ID 14012 DEBUG | 11:16:52.242 | PDEC_REBOOT | P1 Hex: 0x0 | P1 Dec: 0 | P2 Hex: 0x0 | P2 Dec: 0 ERROR | 11:16:52.666 | Sending a reboot command has failed DEBUG | 11:16:52.666 | InternalErrorReporter::performOperation: Errors occured: Queue | TM | Store : 1 | 0 | 0 INFO | 11:16:52.766 | Executing command: writeprotect 1 1 1 Can't lock already locked copy Could not writeprotect chip 1, copy 1 lock 1 INFO | 11:16:52.827 | Graceful shutdown handling done DEBUG | 11:16:52.842 | EventManager: EIVE_SYSTEM reported event with ID 14012 DEBUG | 11:16:52.842 | PDEC_REBOOT | P1 Hex: 0x0 | P1 Dec: 0 | P2 Hex: 0x0 | P2 Dec: 0 re-booting in 3ERROR | 11:16:53.166 | Sending a reboot command has failed ```
meggert commented 2023-08-01 13:39:36 +02:00
Owner
Copy Link

seems to be caused by the sleeps within the core controller reboot function. another delay before the result checking seems to fix the event and command queue spam

seems to be caused by the sleeps within the core controller reboot function. another delay before the result checking seems to fix the event and command queue spam
meggert reviewed 2023-08-01 13:44:32 +02:00
mission/system/EiveSystem.cpp Outdated
@ -200,2 +202,2 @@
// Send full reboot request to core controller.
sendFullRebootCommand();
// Send reboot request to core controller.
ReturnValue_t result = sendSelfRebootCommand();
meggert commented 2023-08-01 13:44:19 +02:00
Owner
Copy Link

shadows previous declaration

shadows previous declaration
meggert marked this conversation as resolved
muellerr added 1 commit 2023-08-02 09:01:29 +02:00
EIVE/eive-obsw/pipeline/pr-main This commit looks good Details
988da377b1
pause the tasks waiting for a reboot
meggert approved these changes 2023-08-02 09:07:10 +02:00
muellerr added 1 commit 2023-08-02 09:19:49 +02:00
EIVE/eive-obsw/pipeline/pr-main Build started... Details
4b4dd35b55
this is the cleanest solution
muellerr added 1 commit 2023-08-02 09:23:05 +02:00
EIVE/eive-obsw/pipeline/pr-main Build queued... Details
6d18e21edf
removed stray return
muellerr added 1 commit 2023-08-02 09:25:06 +02:00
EIVE/eive-obsw/pipeline/pr-main Build queued... Details
949ac8942d
small corrections
muellerr merged commit 0ea0322e45 into main 2023-08-02 09:27:27 +02:00
muellerr deleted branch pdec-reboot-target-self-image 2023-08-02 09:27:28 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
meggert
Labels
Clear labels   
OPS TODO

Issues identified by OPS

  
api change

API change

  
breaking api change

API change which can break existing code

  
bug

Something is not working

  
documentation

Documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
OPS TODO
api change
breaking api change
bug
documentation
duplicate
feature
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
v6.3.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: eive/eive-obsw#763
No description provided.
Delete Branch "pdec-reboot-target-self-image"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?