WIP: Start impl auto switch feature #811

Closed

muellerr wants to merge 11 commits from auto-switch-image-feature into main

pull from: auto-switch-image-feature

merge into: eive:main

eive:main

eive:detumble-mekf

eive:mpsoc-file-split

eive:mohr/introspection

Conversation 4 Commits 11 Files Changed 7 +71 -2

muellerr commented 2023-10-19 14:30:21 +02:00

Owner

Copy Link

TMTC PR: https://egit.irs.uni-stuttgart.de/eive/eive-tmtc/pulls/246/files

TMTC PR: https://egit.irs.uni-stuttgart.de/eive/eive-tmtc/pulls/246/files

muellerr added 1 commit 2023-10-19 14:30:22 +02:00

start impl auto switch feature 2e210a0572

muellerr added this to the v7.2.0 milestone 2023-10-19 14:30:30 +02:00

muellerr added 1 commit 2023-10-19 14:43:52 +02:00

that should get the job done 01ce1f154e

muellerr added 1 commit 2023-10-19 15:06:27 +02:00

bump tmtc befe7ec441

muellerr added 2 commits 2023-10-19 15:18:41 +02:00

better printout fecaad7af7

delay 674202c6fb

muellerr added 1 commit 2023-10-19 15:23:24 +02:00

works f0ade7274a

muellerr changed title from WIP: Start impl auto switch feature to Start impl auto switch feature 2023-10-19 15:23:39 +02:00

muellerr requested review from meggert 2023-10-19 15:24:02 +02:00

muellerr added 1 commit 2023-10-19 15:24:53 +02:00

tiny tweak 18bcb434e9

meggert requested changes 2023-10-20 13:08:29 +02:00

meggert left a comment

Owner

Copy Link

Changelog missing.
Also not sure what this is. To me it looks like the OBSW will always boot to the Target Image, no matter what. Am I missing something? Or is the mechanism not finished yet?

Changelog missing. Also not sure what this is. To me it looks like the OBSW will always boot to the Target Image, no matter what. Am I missing something? Or is the mechanism not finished yet?

muellerr added 1 commit 2023-10-23 13:31:03 +02:00

changelog 4fd18e94fd

muellerr added 1 commit 2023-10-23 13:39:48 +02:00

add link 4e0842c607

muellerr commented 2023-10-23 13:40:48 +02:00

Author

Owner

Copy Link

Added changelog entry. For more information, also see new redmine entry: https://egit.irs.uni-stuttgart.de/redmine/projects/eive-flight-manual/wiki/OBC_Auto_Switch_Image

This mechanism will only trigger once it has been activated explicitely. It is also self-clearing / one-shot: The key value pair triggering the mechanism will be cleared after the reboot.

Added changelog entry. For more information, also see new redmine entry: https://egit.irs.uni-stuttgart.de/redmine/projects/eive-flight-manual/wiki/OBC_Auto_Switch_Image This mechanism will only trigger once it has been activated explicitely. It is also self-clearing / one-shot: The key value pair triggering the mechanism will be cleared after the reboot.

meggert commented 2023-10-26 09:19:29 +02:00

Owner

Copy Link

Added changelog entry. For more information, also see new redmine entry: https://egit.irs.uni-stuttgart.de/redmine/projects/eive-flight-manual/wiki/OBC_Auto_Switch_Image

This mechanism will only trigger once it has been activated explicitely. It is also self-clearing / one-shot: The key value pair triggering the mechanism will be cleared after the reboot.

I do understand how it works, I am just not sure it is usefull like this. If we update 0 0, what information do we gain about the updated image with this feature, if it reboots more or less instantly.

Also this way a manual reboot SELF will lead to 2 reboots to the same image.

> Added changelog entry. For more information, also see new redmine entry: https://egit.irs.uni-stuttgart.de/redmine/projects/eive-flight-manual/wiki/OBC_Auto_Switch_Image > > This mechanism will only trigger once it has been activated explicitely. It is also self-clearing / one-shot: The key value pair triggering the mechanism will be cleared after the reboot. I do understand how it works, I am just not sure it is usefull like this. If we update 0 0, what information do we gain about the updated image with this feature, if it reboots more or less instantly. Also this way a manual reboot SELF will lead to 2 reboots to the same image.

muellerr commented 2023-10-26 10:17:45 +02:00

Author

Owner

Copy Link

It's not about information, it is about safety. If the 0 0 image OBSW binary is updated, but not the firmware/dtb (HPC, connection loss, cosmic snipe whatever..) , the Linux/OBSW might crash horribly. We still have the other reboot mechanism, but I do not 100 % trust only this mechanism. The auto switch image would be a one-shot fallback to just prevent the OBC from booting a (temporarily) broken image. After successfully updating everythng (nominal case unless we're terribly unlucky), we clear the flag and test the image normally. It's just a temporary safety layer for the 0 0 update I guess.

It's not about information, it is about safety. If the 0 0 image OBSW binary is updated, but not the firmware/dtb (HPC, connection loss, cosmic snipe whatever..) , the Linux/OBSW might crash horribly. We still have the other reboot mechanism, but I do not 100 % trust only this mechanism. The auto switch image would be a one-shot fallback to just prevent the OBC from booting a (temporarily) broken image. After successfully updating everythng (nominal case unless we're terribly unlucky), we clear the flag and test the image normally. It's just a temporary safety layer for the 0 0 update I guess.

muellerr modified the milestone from v7.2.0 to v7.3.0 2023-10-27 12:49:24 +02:00

muellerr added 1 commit 2023-10-30 14:45:10 +01:00

Merge remote-tracking branch 'origin/main' into auto-switch-image-feature 8e1f95ebf2

muellerr added 1 commit 2023-10-30 15:02:27 +01:00

Merge branch 'main' into auto-switch-image-feature c12706ef05

muellerr changed title from Start impl auto switch feature to WIP: Start impl auto switch feature 2023-10-30 15:50:10 +01:00

muellerr modified the milestone from v7.3.0 to v7.3.0 2023-10-30 15:54:57 +01:00

muellerr modified the milestone from v7.3.0 to v7.4.0 2023-11-06 14:39:18 +01:00

meggert modified the milestone from v7.4.0 to v7.4.1 2023-11-24 09:04:10 +01:00

meggert modified the milestone from v7.4.1 to v7.5.1 2023-12-06 11:53:06 +01:00

meggert modified the milestone from v7.5.1 to v7.5.2 2023-12-13 16:57:41 +01:00

meggert modified the milestone from v7.5.2 to v7.5.3 2023-12-13 18:03:13 +01:00

muellerr modified the milestone from v7.5.3 to v7.7.1 2023-12-19 13:02:06 +01:00

meggert removed this from the v7.7.1 milestone 2024-02-29 16:07:49 +01:00

meggert commented 2024-03-27 11:44:34 +01:00

Owner

Copy Link

no plan on implementing this anytime soon

no plan on implementing this anytime soon

meggert closed this pull request 2024-03-27 11:44:34 +01:00

All checks were successful

Hide all checks

EIVE/eive-obsw/pipeline/pr-main This commit looks good

Details

EIVE/eive-obsw/pipeline/head This commit looks good

Details

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

No reviewers

meggert

Labels

Clear labels   

OPS TODO

Issues identified by OPS

  

api change

API change

  

breaking api change

API change which can break existing code

  

bug

Something is not working

  

documentation

Documentation

  

duplicate

This issue or pull request already exists

  

feature

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

wontfix

This won't be fixed

No Label

OPS TODO

api change

breaking api change

bug

documentation

duplicate

feature

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: eive/eive-obsw#811

No description provided.