eive/eive-obsw
eive/eive-obsw
13
4
Fork 0
Code Issues 4 Pull Requests 1 Releases 120 Wiki Activity

Fix NaN for Limiting Rotation Rates #872

Merged
meggert merged 17 commits from limit-rot-rate-fix into main 2024-03-06 11:13:02 +01:00
Conversation 0 Commits 17 Files Changed 12 +116 -8
meggert commented 2024-03-01 15:30:31 +01:00
Owner
Copy Link
No description provided.
meggert added this to the v7.7.1 milestone 2024-03-01 15:30:31 +01:00
meggert added the
bug
 label 2024-03-01 15:30:31 +01:00
meggert added 2 commits 2024-03-01 15:30:32 +01:00
prevent ctrl values from becoming NaN
Some checks are pending
EIVE/eive-obsw/pipeline/head Build started...
Details
141f82d0a9
changelog
Some checks are pending
EIVE/eive-obsw/pipeline/head Build started...
Details
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
6da37c0fa4
meggert added 1 commit 2024-03-04 11:57:27 +01:00
use existing function
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
cda2a9df33
meggert added 1 commit 2024-03-05 09:07:05 +01:00
prep for leap seconds
Some checks failed
EIVE/eive-obsw/pipeline/pr-main There was a failure building this commit
Details
2a2a173ebd
meggert added 1 commit 2024-03-05 11:51:21 +01:00
act cmd
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
85ed8420fd
meggert added 1 commit 2024-03-05 13:08:47 +01:00
whoops
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
440d989490
meggert added 1 commit 2024-03-05 13:48:25 +01:00
should be enough
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
c2d8ef9fe4
meggert added 1 commit 2024-03-05 14:09:57 +01:00
meggert added 1 commit 2024-03-05 14:10:49 +01:00
-
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
39032249b2
meggert added 1 commit 2024-03-05 14:30:31 +01:00
bumped fsfw
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
fb8a92ecb5
meggert added 1 commit 2024-03-05 15:49:25 +01:00
changelog
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
c52818a5ce
meggert added 2 commits 2024-03-06 09:47:12 +01:00
fsfw
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
3501763cf0
meggert added 1 commit 2024-03-06 09:47:51 +01:00
changelog
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
616803c6a8
meggert added a new dependency 2024-03-06 09:48:47 +01:00
eive/fsfw#170 - Removed duplicate Code
meggert added a new dependency 2024-03-06 09:48:52 +01:00
eive/eive-tmtc#281 - Leap Seconds
meggert requested review from muellerr 2024-03-06 09:49:02 +01:00
meggert changed title from WIP: Fix NaN for Limiting Rotation Rates to Fix NaN for Limiting Rotation Rates 2024-03-06 09:49:07 +01:00
meggert added 1 commit 2024-03-06 10:18:19 +01:00
Merge branch 'main' into limit-rot-rate-fix
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
d0765fdcce
muellerr reviewed 2024-03-06 10:23:26 +01:00
bsp_q7s/core/CoreController.cpp Outdated
@ -79,6 +79,7 @@ CoreController::CoreController(object_id_t objectId, bool enableHkSet)
} catch (const std::filesystem::filesystem_error &e) {
sif::error << "CoreController::CoreController: Failed with exception " << e.what() << std::endl;
}
initLeapSeconds();
muellerr commented 2024-03-06 10:23:26 +01:00
Owner
Copy Link

shouldn't this be inside the function above? If this is done, the default value setting needs to be moved to constructor/initialize function so it is always executed..

shouldn't this be inside the function above? If this is done, the default value setting needs to be moved to constructor/initialize function so it is always executed..
meggert commented 2024-03-06 10:25:50 +01:00
Author
Owner
Copy Link

the function will initialize the leap seconds, no matter what. it could be up there yes, but a try catch for a function that will definitely do what it needs to be doing seemed unnecessary

the function will initialize the leap seconds, no matter what. it could be up there yes, but a try catch for a function that will definitely do what it needs to be doing seemed unnecessary
meggert added 2 commits 2024-03-06 11:10:40 +01:00
bumped submodules
Some checks are pending
EIVE/eive-obsw/pipeline/pr-main Build started...
Details
781feffc90
meggert merged commit c2a4578b81 into main 2024-03-06 11:13:02 +01:00
meggert deleted branch limit-rot-rate-fix 2024-03-06 11:13:03 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
muellerr
Labels
Clear labels   
OPS TODO

Issues identified by OPS

  
api change

API change

  
breaking api change

API change which can break existing code

  
bug

Something is not working

  
documentation

Documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
OPS TODO
api change
breaking api change
bug
documentation
duplicate
feature
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
v7.7.1
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on
#170 Removed duplicate Code
eive/fsfw
#281 Leap Seconds
eive/eive-tmtc
Reference: eive/eive-obsw#872
No description provided.
Delete Branch "limit-rot-rate-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?