eive/eive-obsw
eive/eive-obsw
13
4
Fork 0
Code Issues 4 Pull Requests 1 Releases 120 Wiki Activity

Fix NaN for Limiting Rotation Rates #872

Merged
meggert merged 17 commits from limit-rot-rate-fix into main 2024-03-06 11:13:02 +01:00
Conversation 0 Commits 17 Files Changed 12 +5 -1
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit efaf48beff - Show all commits

6
bsp_q7s/core/CoreController.cpp
View File

@ -79,6 +79,7 @@ CoreController::CoreController(object_id_t objectId, bool enableHkSet)
} catch (const std::filesystem::filesystem_error &e) { } catch (const std::filesystem::filesystem_error &e) {
sif::error << "CoreController::CoreController: Failed with exception " << e.what() << std::endl; sif::error << "CoreController::CoreController: Failed with exception " << e.what() << std::endl;
} }
initLeapSeconds();
muellerr commented 2024-03-06 10:23:26 +01:00
Outdated
Review
Copy Link

shouldn't this be inside the function above? If this is done, the default value setting needs to be moved to constructor/initialize function so it is always executed..

shouldn't this be inside the function above? If this is done, the default value setting needs to be moved to constructor/initialize function so it is always executed..
meggert commented 2024-03-06 10:25:50 +01:00
Outdated
Review
Copy Link

the function will initialize the leap seconds, no matter what. it could be up there yes, but a try catch for a function that will definitely do what it needs to be doing seemed unnecessary

the function will initialize the leap seconds, no matter what. it could be up there yes, but a try catch for a function that will definitely do what it needs to be doing seemed unnecessary
// Add script folder to path // Add script folder to path
char *currentEnvPath = getenv("PATH"); char *currentEnvPath = getenv("PATH");
std::string updatedEnvPath = std::string(currentEnvPath) + ":/home/root/scripts:/usr/local/bin"; std::string updatedEnvPath = std::string(currentEnvPath) + ":/home/root/scripts:/usr/local/bin";
@ -2109,6 +2110,9 @@ ReturnValue_t CoreController::initLeapSecondsFromFile() {
Clock::setLeapSeconds(leapSeconds); Clock::setLeapSeconds(leapSeconds);
return returnvalue::OK; return returnvalue::OK;
} }
sif::error
<< "CoreController::leapSecondsFileHandler: Initalization of leap seconds from file failed"
<< std::endl;
return returnvalue::FAILED; return returnvalue::FAILED;
}; };
@ -2119,7 +2123,7 @@ ReturnValue_t CoreController::writeLeapSecondsToFile(const uint16_t leapSeconds)
} }
std::ofstream leapSecondsFile(fileName.c_str(), std::ofstream::out | std::ofstream::trunc); std::ofstream leapSecondsFile(fileName.c_str(), std::ofstream::out | std::ofstream::trunc);
if (not leapSecondsFile.good()) { if (not leapSecondsFile.good()) {
sif::error << "CoreController::leapSecondsFileHandler: Error opening time file: " sif::error << "CoreController::leapSecondsFileHandler: Error opening leap seconds file: "
<< strerror(errno) << std::endl; << strerror(errno) << std::endl;
return returnvalue::FAILED; return returnvalue::FAILED;
} }