eive/fsfw
eive
/
fsfw
forked from fsfw/fsfw
14
1
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

no virtual inhertience for now

This commit is contained in:
Robin Müller 2021-03-11 01:04:39 +01:00
parent 78b6a83285
commit 824f272432
4 changed files with 17 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
datapool/PoolDataSetIF.h
View File

@ -9,8 +9,8 @@
* and unlock a data pool and read/commit semantics.
*/
class PoolDataSetIF:
public DataSetIF,
public ReadCommitIF {
virtual public DataSetIF,
virtual public ReadCommitIF {
public:
virtual~ PoolDataSetIF() {};

3
datapool/SharedDataSetIF.h
View File

@ -3,8 +3,7 @@
#include "PoolDataSetIF.h"
class SharedDataSetIF:
public PoolDataSetIF {
class SharedDataSetIF {
public:
virtual ~SharedDataSetIF() {};

12
unittest/tests/datapoollocal/DataSetTest.cpp
View File

@ -254,12 +254,12 @@ TEST_CASE("DataSetTest" , "[DataSetTest]") {
}
SECTION("SharedDataSet") {
// object_id_t sharedSetId = objects::SHARED_SET_ID;
// SharedLocalDataSet sharedSet(sharedSetId, poolOwner, 2, 5);
// CHECK(sharedSet.initialize() == retval::CATCH_OK);
// CHECK(sharedSet.lockDataset() == retval::CATCH_OK);
//
// CHECK(sharedSet.unlockDataset() == retval::CATCH_OK);
object_id_t sharedSetId = objects::SHARED_SET_ID;
SharedLocalDataSet sharedSet(sharedSetId, poolOwner, 2, 5);
CHECK(sharedSet.initialize() == retval::CATCH_OK);
CHECK(sharedSet.lockDataset() == retval::CATCH_OK);
CHECK(sharedSet.unlockDataset() == retval::CATCH_OK);
}
/* we need to reset the subscription list because the pool owner

10
unittest/tests/datapoollocal/LocalPoolOwnerBase.h
View File

@ -36,7 +36,8 @@ static const gp_id_t uint64Vec2Id = gp_id_t(objects::TEST_LOCAL_POOL_OWNER_BASE,
class LocalPoolStaticTestDataSet: public StaticLocalDataSet<3> {
public:
LocalPoolStaticTestDataSet():
StaticLocalDataSet(lpool::testSid) {
StaticLocalDataSet(lpool::testSid) {
}
LocalPoolStaticTestDataSet(HasLocalDataPoolIF* owner, uint32_t setId):
@ -53,7 +54,12 @@ private:
class LocalPoolTestDataSet: public LocalDataSet {
public:
LocalPoolTestDataSet():
LocalDataSet(lpool::testSid, lpool::dataSetMaxVariables) {
LocalDataSet(lpool::testSid, lpool::dataSetMaxVariables),
localPoolVarUint8(lpool::uint8VarGpid, this),
localPoolVarFloat(lpool::floatVarGpid, this),
localPoolUint16Vec(lpool::uint16Vec3Gpid, this)
{
}
LocalPoolTestDataSet(HasLocalDataPoolIF* owner, uint32_t setId):