using uint32_t for getIdentifier of AcceptsTcIF

src/fsfw/cfdp/CfdpHandler.cpp

@@ -52,6 +52,6 @@ ReturnValue_t CfdpHandler::performOperation(uint8_t opCode) {
   return RETURN_OK;
 }
 
-uint16_t CfdpHandler::getIdentifier() { return 0; }
+uint32_t CfdpHandler::getIdentifier() { return 0; }
 
 MessageQueueId_t CfdpHandler::getRequestQueue() { return this->requestQueue->getId(); }

src/fsfw/cfdp/CfdpHandler.h

@@ -28,7 +28,7 @@ class CfdpHandler : public ExecutableObjectIF,
   virtual ReturnValue_t handleRequest(store_address_t storeId);
 
   virtual ReturnValue_t initialize() override;
-  virtual uint16_t getIdentifier() override;
+  virtual uint32_t getIdentifier() override;
   MessageQueueId_t getRequestQueue() override;
   ReturnValue_t performOperation(uint8_t opCode) override;
 

src/fsfw/tcdistribution/CMakeLists.txt

@@ -6,4 +6,5 @@ target_sources(
           PusPacketChecker.cpp
           TcPacketCheckCFDP.cpp
           CfdpDistributor.cpp
-          CcsdsPacketChecker.cpp)
+          CcsdsPacketChecker.cpp
+          CcsdsUnpacker.cpp)

src/fsfw/tcdistribution/CcsdsDistributor.cpp

@@ -80,7 +80,7 @@ ReturnValue_t CcsdsDistributor::registerApplication(uint16_t apid, MessageQueueI
   return returnValue;
 }
 
-uint16_t CcsdsDistributor::getIdentifier() { return 0; }
+uint32_t CcsdsDistributor::getIdentifier() { return 0; }
 
 ReturnValue_t CcsdsDistributor::initialize() {
   if (packetChecker == nullptr) {

src/fsfw/tcdistribution/CcsdsDistributor.h

@@ -38,7 +38,7 @@ class CcsdsDistributor : public TcDistributor,
   MessageQueueId_t getRequestQueue() override;
   ReturnValue_t registerApplication(uint16_t apid, MessageQueueId_t id) override;
   ReturnValue_t registerApplication(AcceptsTelecommandsIF* application) override;
-  uint16_t getIdentifier() override;
+  uint32_t getIdentifier() override;
   ReturnValue_t initialize() override;
 
  protected:

src/fsfw/tcdistribution/CcsdsUnpacker.cpp

@@ -0,0 +1,7 @@
+#include "CcsdsUnpacker.h"
+
+CcsdsUnpacker::CcsdsUnpacker() {}
+
+ReturnValue_t CcsdsUnpacker::performOperation(uint8_t operationCode) { return 0; }
+uint32_t CcsdsUnpacker::getIdentifier() { return 0; }
+MessageQueueId_t CcsdsUnpacker::getRequestQueue() { return 0; }

src/fsfw/tcdistribution/CcsdsUnpacker.h

@@ -0,0 +1,16 @@
+#ifndef FSFW_TCDISTRIBUTION_CCSDSUNPACKER_H
+#define FSFW_TCDISTRIBUTION_CCSDSUNPACKER_H
+
+#include "fsfw/tasks/ExecutableObjectIF.h"
+#include "fsfw/tmtcservices/AcceptsTelecommandsIF.h"
+
+class CcsdsUnpacker: public ExecutableObjectIF, public AcceptsTelecommandsIF {
+ public:
+  CcsdsUnpacker();
+  ReturnValue_t performOperation(uint8_t operationCode) override;
+  uint32_t getIdentifier() override;
+  MessageQueueId_t getRequestQueue() override;
+
+ private:
+};
+#endif  // FSFW_TCDISTRIBUTION_CCSDSUNPACKER_H

src/fsfw/tcdistribution/CfdpDistributor.cpp

@@ -118,7 +118,7 @@ MessageQueueId_t CfdpDistributor::getRequestQueue() { return tcQueue->getId(); }
 //     }
 // }
 
-uint16_t CfdpDistributor::getIdentifier() { return this->apid; }
+uint32_t CfdpDistributor::getIdentifier() { return this->apid; }
 
 ReturnValue_t CfdpDistributor::initialize() {
   currentPacket = new CfdpPacketStored();

src/fsfw/tcdistribution/CfdpDistributor.h

@@ -35,7 +35,7 @@ class CfdpDistributor : public TcDistributor,
   ReturnValue_t registerHandler(AcceptsTelecommandsIF* handler) override;
   MessageQueueId_t getRequestQueue() override;
   ReturnValue_t initialize() override;
-  uint16_t getIdentifier() override;
+  uint32_t getIdentifier() override;
 
  protected:
   uint16_t apid;

src/fsfw/tcdistribution/PusDistributor.cpp

@@ -117,7 +117,7 @@ ReturnValue_t PusDistributor::callbackAfterSending(ReturnValue_t queueStatus) {
   }
 }
 
-uint16_t PusDistributor::getIdentifier() { return checker.getApid(); }
+uint32_t PusDistributor::getIdentifier() { return checker.getApid(); }
 
 ReturnValue_t PusDistributor::initialize() {
   if (store == nullptr) {

src/fsfw/tcdistribution/PusDistributor.h

@@ -36,7 +36,7 @@ class PusDistributor : public TcDistributor, public PusDistributorIF, public Acc
   ReturnValue_t registerService(AcceptsTelecommandsIF* service) override;
   MessageQueueId_t getRequestQueue() override;
   ReturnValue_t initialize() override;
-  uint16_t getIdentifier() override;
+  uint32_t getIdentifier() override;
 
  protected:
   StorageManagerIF* store;

src/fsfw/tmtcservices/AcceptsTelecommandsIF.h

@@ -22,13 +22,13 @@ class AcceptsTelecommandsIF {
    */
   virtual ~AcceptsTelecommandsIF() = default;
   /**
-   * @brief	Getter for the service id.
-   * @details	Any receiving service (at least any PUS service) shall have a
-   * 			service ID. If the receiver can handle Telecommands, but for
-   * 			some reason has no service id, it shall return 0.
-   * @return	The service ID or 0.
+   * @brief	Getter for a generic identifier ID.
+   * @details	Any receiving service (at least any PUS service) shall have an identifier. For
+   *    example, this could be the APID for a receiver expecting generic PUS packets, or a PUS
+   *    service for a component expecting specific PUS service packets.
+   * @return	The identifier.
    */
-  virtual uint16_t getIdentifier() = 0;
+  virtual uint32_t getIdentifier() = 0;
   /**
    * @brief	This method returns the message queue id of the telecommand
    * 			receiving message queue.

src/fsfw/tmtcservices/CommandingServiceBase.cpp

@@ -50,7 +50,7 @@ ReturnValue_t CommandingServiceBase::performOperation(uint8_t opCode) {
   return RETURN_OK;
 }
 
-uint16_t CommandingServiceBase::getIdentifier() { return service; }
+uint32_t CommandingServiceBase::getIdentifier() { return service; }
 
 MessageQueueId_t CommandingServiceBase::getRequestQueue() { return requestQueue->getId(); }
 

src/fsfw/tmtcservices/CommandingServiceBase.h

@@ -106,7 +106,7 @@ class CommandingServiceBase : public SystemObject,
    */
   ReturnValue_t performOperation(uint8_t opCode) override;
 
-  uint16_t getIdentifier() override;
+  uint32_t getIdentifier() override;
 
   /**
    * Returns the requestQueue MessageQueueId_t

src/fsfw/tmtcservices/PusServiceBase.cpp

@@ -82,7 +82,7 @@ void PusServiceBase::handleRequestQueue() {
   }
 }
 
-uint16_t PusServiceBase::getIdentifier() { return psbParams.serviceId; }
+uint32_t PusServiceBase::getIdentifier() { return psbParams.serviceId; }
 
 MessageQueueId_t PusServiceBase::getRequestQueue() {
   if (psbParams.reqQueue == nullptr) {

src/fsfw/tmtcservices/PusServiceBase.h

@@ -188,7 +188,7 @@ class PusServiceBase : public ExecutableObjectIF,
    * 			@c RETURN_FAILED else.
    */
   ReturnValue_t performOperation(uint8_t opCode) override;
-  uint16_t getIdentifier() override;
+  uint32_t getIdentifier() override;
   MessageQueueId_t getRequestQueue() override;
   ReturnValue_t initialize() override;
 

src/fsfw/tmtcservices/TmTcBridge.cpp

@@ -247,7 +247,7 @@ MessageQueueId_t TmTcBridge::getReportReceptionQueue(uint8_t virtualChannel) {
 
 void TmTcBridge::printData(uint8_t* data, size_t dataLen) { arrayprinter::print(data, dataLen); }
 
-uint16_t TmTcBridge::getIdentifier() {
+uint32_t TmTcBridge::getIdentifier() {
   // This is no PUS service, so we just return 0
   return 0;
 }

src/fsfw/tmtcservices/TmTcBridge.h

@@ -69,7 +69,7 @@ class TmTcBridge : public AcceptsTelemetryIF,
   virtual MessageQueueId_t getReportReceptionQueue(uint8_t virtualChannel = 0) override;
 
   /** AcceptsTelecommandsIF override */
-  virtual uint16_t getIdentifier() override;
+  virtual uint32_t getIdentifier() override;
   virtual MessageQueueId_t getRequestQueue() override;
 
  protected: