changelog

logic error
that time margin check is possible broken
2023-02-09 18:22:00 +01:00 · 2023-02-09 18:18:25 +01:00 · 2023-02-09 18:18:05 +01:00
2 changed files with 4 additions and 1 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@ -12,6 +12,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ## Fixes
 - Bugfix in `Service11TelecommandScheduling` which allowed commands
  time tagged in the past to be inserted.
  PR: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/pulls/738
 - `CService200ModeManagement`: Various bugfixes which lead to now execution complete being generated
  on mode announcements, duplicate mode reply generated on announce commands, and the mode read
  subservice not working properly.
--- a/src/fsfw/pus/Service11TelecommandScheduling.tpp
+++ b/src/fsfw/pus/Service11TelecommandScheduling.tpp
@ -160,7 +160,7 @@ inline ReturnValue_t Service11TelecommandScheduling<MAX_NUM_TCS>::doInsertActivi
  // (See requirement for Time margin)
  timeval tNow = {};
  Clock::getClock_timeval(&tNow);
-  if (timestamp - tNow.tv_sec <= RELEASE_TIME_MARGIN_SECONDS) {
+  if (timestamp < tNow.tv_sec + RELEASE_TIME_MARGIN_SECONDS) {
 #if FSFW_CPP_OSTREAM_ENABLED == 1
    sif::warning << "Service11TelecommandScheduling::doInsertActivity: Release time too close to "
                    "current time"
Author	SHA1	Message	Date
Robin Mueller	341a66c265	changelog	2023-02-09 18:22:00 +01:00
Robin Mueller	b9b076aa4c	logic error	2023-02-09 18:18:25 +01:00
Robin Mueller	d93486a340	that time margin check is possible broken	2023-02-09 18:18:05 +01:00