eive/fsfw
15
1
Fork 0
forked from fsfw/fsfw
Code Issues Pull Requests Releases 1 Wiki Activity

re-work some FDIR logic #172

Merged
muellerr merged 2 commits from improve-dev-fdir into develop 2024-04-09 10:47:33 +02:00
Conversation 2 Commits 2 Files Changed 4
+25 -26
muellerr commented 2024-04-03 12:50:03 +02:00
Owner
Copy Link
Copy Source
No description provided.
muellerr added 1 commit 2024-04-03 12:50:04 +02:00
re-work some FDIR logic 203c0bac5c
muellerr requested review from gaisser 2024-04-03 12:50:09 +02:00
muellerr added 1 commit 2024-04-03 12:52:35 +02:00
optimize docs c5159fb645
gaisser left a comment
Member
Copy Link
Copy Source

Please check if it is ok to trigger events during fdirState == NONE.

Please check if it is ok to trigger events during fdirState == NONE.
src/fsfw/devicehandlers/DeviceHandlerFailureIsolation.cpp
@@ -186,15 +191,6 @@ void DeviceHandlerFailureIsolation::setFdirState(FDIRState state) {
fdirState = state;
}
void DeviceHandlerFailureIsolation::triggerEvent(Event event, uint32_t parameter1,
gaisser commented 2024-04-04 20:52:57 +02:00
Member
Copy Link
Copy Source

Is this function not called or why remove it?

If the base function is used instead, events will get triggered during recoveries which might break stuff.

Is this function not called or why remove it? If the base function is used instead, events will get triggered during recoveries which might break stuff.
muellerr commented 2024-04-05 13:00:59 +02:00
Author
Owner
Copy Link
Copy Source

Aren't FDIR reactions ignored if the FDIR is active? Also, aren't there cases where I'd at least want to see the events even if the FDIR is active?

Aren't FDIR reactions ignored if the FDIR is active? Also, aren't there cases where I'd at least want to see the events even if the FDIR is active?
gaisser commented 2024-04-05 15:21:45 +02:00
Member
Copy Link
Copy Source

I don't know for sure. what will happen if another event is triggered during recoveries. For now it seems ok as the FDIR does not react. Although, higher level FDIRs will react if the system has any.

I don't know for sure. what will happen if another event is triggered during recoveries. For now it seems ok as the FDIR does not react. Although, higher level FDIRs will react if the system has any.
gaisser commented 2024-04-05 15:22:26 +02:00
Member
Copy Link
Copy Source

Have you watched any events during testing while in recovery? it might filter event spam.

Have you watched any events during testing while in recovery? it might filter event spam.
muellerr commented 2024-04-08 13:54:53 +02:00
Author
Owner
Copy Link
Copy Source

I think this should be fine.. isn't is a configuration error if a device throws tons of unexpected events for reboot handling or when being faulty? I tested this for EIVE and did not receive any unexpected event spam so far.

I think this should be fine.. isn't is a configuration error if a device throws tons of unexpected events for reboot handling or when being faulty? I tested this for EIVE and did not receive any unexpected event spam so far.
muellerr commented 2024-04-05 13:03:54 +02:00
Author
Owner
Copy Link
Copy Source

You mean events with severity higher than INFO while the FDIR is IDLE? This was already tested.

You mean events with severity higher than INFO while the FDIR is IDLE? This was already tested.
muellerr merged commit e6e3753324 into develop 2024-04-09 10:47:33 +02:00
muellerr deleted branch improve-dev-fdir 2024-04-09 10:47:34 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
gaisser
Labels
Clear labels
api change
API change
 breaking api change
API change which can break existing code
 bug
Something is not working
 documentation
Documentation
 duplicate
This issue or pull request already exists
 feature
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
ahinkel (Andy Hinkel) jenkins_buildfix lkoester meggert (Marius Eggert) meierj (Jakob Meier) mkoller mkranz mohr (Ulrich Mohr) msenger (Mikael Senger) muellerr (Robin Müller) rschweigert steinertm (Michael Steinert) zinkj
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: eive/fsfw#172