re-work some FDIR logic #172

muellerr · 2024-04-03T12:50:03+02:00

muellerr commented

2024-04-03 12:50:03 +02:00

No description provided.

muellerr added 1 commit 2024-04-03 12:50:04 +02:00

203c0bac5c

re-work some FDIR logic

muellerr requested review from gaisser 2024-04-03 12:50:09 +02:00

muellerr added 1 commit 2024-04-03 12:52:35 +02:00

c5159fb645

optimize docs

gaisser requested changes 2024-04-04 20:55:57 +02:00

gaisser left a comment

Please check if it is ok to trigger events during fdirState == NONE.

src/fsfw/devicehandlers/DeviceHandlerFailureIsolation.cpp

						
				@ -186,15 +191,6 @@ void DeviceHandlerFailureIsolation::setFdirState(FDIRState state) {

				  fdirState = state;

				}

				void DeviceHandlerFailureIsolation::triggerEvent(Event event, uint32_t parameter1,

gaisser commented

2024-04-04 20:52:57 +02:00

Is this function not called or why remove it?

If the base function is used instead, events will get triggered during recoveries which might break stuff.

Is this function not called or why remove it? If the base function is used instead, events will get triggered during recoveries which might break stuff.

muellerr commented

2024-04-05 13:00:59 +02:00

Aren't FDIR reactions ignored if the FDIR is active? Also, aren't there cases where I'd at least want to see the events even if the FDIR is active?

gaisser commented

2024-04-05 15:21:45 +02:00

I don't know for sure. what will happen if another event is triggered during recoveries. For now it seems ok as the FDIR does not react. Although, higher level FDIRs will react if the system has any.

gaisser commented

2024-04-05 15:22:26 +02:00

Have you watched any events during testing while in recovery? it might filter event spam.

muellerr commented

2024-04-08 13:54:53 +02:00

I think this should be fine.. isn't is a configuration error if a device throws tons of unexpected events for reboot handling or when being faulty? I tested this for EIVE and did not receive any unexpected event spam so far.