meier/tcpFix #23

meierj · 2021-10-08T13:56:32+02:00

meierj commented

2021-10-08 13:56:32 +02:00

TCP Server only parsed TCs in case of receive errors
when client closed connection, valid packets remained in ring buffer until next receive error occured

* TCP Server only parsed TCs in case of receive errors * when client closed connection, valid packets remained in ring buffer until next receive error occured

meierj added the

bug

label 2021-10-08 13:56:32 +02:00

muellerr was assigned by meierj

2021-10-08 13:56:32 +02:00

meierj added 2 commits 2021-10-08 13:56:33 +02:00

8e65833d60 added bind call error string

a578f0390b tcp server also parses TCs when client closes connection

muellerr commented

2021-10-09 13:27:55 +02:00

The socket call is made with a non-blocking flag, so TC is also read if the client does not send anything (to be precise, if the recv call would block).

It definitely still makes sense to read the packets when the client closes the connection

The socket call is made with a non-blocking flag, so TC is also read if the client does not send anything (to be precise, if the `recv` call would block). It definitely still makes sense to read the packets when the client closes the connection

muellerr approved these changes 2021-10-09 13:28:16 +02:00

muellerr merged commit b985bf5167 into eive/develop

2021-10-09 13:28:49 +02:00

muellerr referenced this issue from a commit

2021-10-09 13:28:49 +02:00

Merge pull request 'meier/tcpFix' (#23) from meier/tcpFix into eive/develop

muellerr deleted branch meier/tcpFix

2021-10-09 13:28:49 +02:00

Sign in to join this conversation.

No reviewers