some more TODOs

This commit is contained in:
Robin Müller 2022-09-07 18:40:10 +02:00
parent dd866790f3
commit 9c9daffbbc
No known key found for this signature in database
GPG Key ID: 71B58F8A3CDFA9AC
2 changed files with 7 additions and 2 deletions

View File

@ -11,7 +11,7 @@ CfdpHandler::CfdpHandler(const HandlerCfg& cfg)
destHandler( destHandler(
DestHandlerParams(cfg.cfg, *this, *this, cfg.packetInfoList, cfg.lostSegmentsList), DestHandlerParams(cfg.cfg, *this, *this, cfg.packetInfoList, cfg.lostSegmentsList),
FsfwParams(cfg.packetDest, nullptr, this)) { FsfwParams(cfg.packetDest, nullptr, this)) {
// TODO: Make configurable? // TODO: Make queue params configurable, or better yet, expect it to be passed externally
msgQueue = QueueFactory::instance()->createMessageQueue(); msgQueue = QueueFactory::instance()->createMessageQueue();
destHandler.setMsgQueue(*msgQueue); destHandler.setMsgQueue(*msgQueue);
} }

View File

@ -33,13 +33,18 @@ class CfdpHandler : public SystemObject,
public AcceptsTelecommandsIF { public AcceptsTelecommandsIF {
public: public:
explicit CfdpHandler(const HandlerCfg& cfg); explicit CfdpHandler(const HandlerCfg& cfg);
bool getRemoteCfg(const cfdp::EntityId& remoteId, cfdp::RemoteEntityCfg** cfg) override;
[[nodiscard]] const char* getName() const override; [[nodiscard]] const char* getName() const override;
[[nodiscard]] uint32_t getIdentifier() const override; [[nodiscard]] uint32_t getIdentifier() const override;
[[nodiscard]] MessageQueueId_t getRequestQueue() const override; [[nodiscard]] MessageQueueId_t getRequestQueue() const override;
ReturnValue_t initialize() override; ReturnValue_t initialize() override;
ReturnValue_t performOperation(uint8_t operationCode) override; ReturnValue_t performOperation(uint8_t operationCode) override;
// CFDP remote table interface
bool getRemoteCfg(const cfdp::EntityId& remoteId, cfdp::RemoteEntityCfg** cfg) override;
// CFDP user overrides
void transactionIndication(const cfdp::TransactionId& id) override; void transactionIndication(const cfdp::TransactionId& id) override;
void eofSentIndication(const cfdp::TransactionId& id) override; void eofSentIndication(const cfdp::TransactionId& id) override;
void transactionFinishedIndication(const cfdp::TransactionFinishedParams& params) override; void transactionFinishedIndication(const cfdp::TransactionFinishedParams& params) override;