important bugfix for verif reporter
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
This commit is contained in:
parent
239d053562
commit
ff6de8e378
@ -105,14 +105,13 @@ ReturnValue_t PusDistributor::callbackAfterSending(ReturnValue_t queueStatus) {
|
||||
tcStatus = queueStatus;
|
||||
}
|
||||
if (tcStatus != RETURN_OK) {
|
||||
verifyChannel->sendFailureReport(
|
||||
VerifFailureParams(tcverif::ACCEPTANCE_FAILURE, reader, tcStatus));
|
||||
verifyChannel->sendFailureReport({tcverif::ACCEPTANCE_FAILURE, reader, tcStatus});
|
||||
// A failed packet is deleted immediately after reporting,
|
||||
// otherwise it will block memory.
|
||||
store->deleteData(currentMessage.getStorageId());
|
||||
return RETURN_FAILED;
|
||||
} else {
|
||||
verifyChannel->sendSuccessReport(VerifSuccessParams(tcverif::ACCEPTANCE_SUCCESS, reader));
|
||||
verifyChannel->sendSuccessReport({tcverif::ACCEPTANCE_SUCCESS, reader});
|
||||
return RETURN_OK;
|
||||
}
|
||||
}
|
||||
|
@ -33,10 +33,7 @@ class VerificationReporter : public SystemObject, public VerificationReporterIF
|
||||
|
||||
void setReceiver(AcceptsVerifyMessageIF& receiver);
|
||||
|
||||
// TODO: The API is a little bit bloated. It might be better to group all the parameters
|
||||
// into a dedicated struct
|
||||
ReturnValue_t sendSuccessReport(VerifSuccessParams params) override;
|
||||
|
||||
ReturnValue_t sendFailureReport(VerifFailureParams params) override;
|
||||
|
||||
static object_id_t DEFAULT_REPORTER;
|
||||
@ -44,7 +41,7 @@ class VerificationReporter : public SystemObject, public VerificationReporterIF
|
||||
ReturnValue_t initialize() override;
|
||||
|
||||
private:
|
||||
MessageQueueId_t acknowledgeQueue;
|
||||
MessageQueueId_t acknowledgeQueue = MessageQueueIF::NO_QUEUE;
|
||||
};
|
||||
|
||||
#endif /* FSFW_TMTCSERVICES_VERIFICATIONREPORTER_H_ */
|
||||
|
Loading…
Reference in New Issue
Block a user