Change all length fields to size_t #12

New Issue

mohr · 2020-02-03T17:34:26+01:00

mohr commented

2020-02-03 17:34:26 +01:00

No description provided.

mohr self-assigned this 2020-02-03 17:34:26 +01:00

mohr added the

feature

label 2020-02-03 17:34:26 +01:00

muellerr commented

2020-03-24 11:40:37 +01:00

Started replacement in DHB rework.

muellerr commented

2020-04-06 17:03:53 +02:00

Replaced uint32_t/int32_t for all SerializeIF calls (ssize_t for int32_t). There are a lot of functions implementing SerializeIF. merge request coming soon

muellerr commented

2020-04-07 11:18:10 +02:00

Is size_t intended to be used in SerializeIF? And how to handle the signed size?( ssize_t)

Possible C++11 solution:

#ifndef ssize_t
typedef std::make_signed<std::size_t>::type ssize_t;
#endif

Is size_t intended to be used in SerializeIF? And how to handle the signed size?( ssize_t) Possible C++11 solution: ```cpp #ifndef ssize_t typedef std::make_signed<std::size_t>::type ssize_t; #endif ```

muellerr commented

2020-04-07 14:22:02 +02:00

After talking with Steffen: Maybe also use size_t for deSerialize and detect overflows by
using

if((*size - sizeToDeserialize) >= *size) {
   return SOME_ERROR_VALUE
}

to check for overflows?
This has potential to create evil bugs if it is not done properly for alle deSerialize calls/overrides

After talking with Steffen: Maybe also use size_t for deSerialize and detect overflows by using ```cpp if((*size - sizeToDeserialize) >= *size) { return SOME_ERROR_VALUE } ``` to check for overflows? This has potential to create evil bugs if it is not done properly for alle deSerialize calls/overrides

mohr commented

2020-04-16 18:46:44 +02:00

#35 started work on this

mohr commented

2020-04-16 18:53:52 +02:00

Is size_t intended to be used in SerializeIF? And how to handle the signed size?( ssize_t)

Possible C++11 solution:
#ifndef ssize_t
typedef std::make_signed<std::size_t>::type ssize_t;
#endif

No need to typedef ssize_t, it is in stdio.h sys/types.h and unistd.h, one of which should be available in a typical installation.

> Is size_t intended to be used in SerializeIF? And how to handle the signed size?( ssize_t) > > Possible C++11 solution: > > ```cpp > #ifndef ssize_t > typedef std::make_signed<std::size_t>::type ssize_t; > #endif > ``` No need to typedef ssize_t, it is in stdio.h sys/types.h and unistd.h, one of which should be available in a typical installation.

mohr added the

API Change

label 2020-04-17 18:02:48 +02:00

muellerr commented

2020-04-18 15:43:09 +02:00

We can just use size_t like discussed for deSerialize.
Example AutoSerializeAdapter:

ReturnValue_t deSerialize(T* object, const uint8_t** buffer, size_t* size,
			bool bigEndian) {
		T tmp;
		if (*size >= sizeof(T)) {
			*size -= sizeof(T);
			memcpy(&tmp, *buffer, sizeof(T));
			if (bigEndian) {
				*object = EndianSwapper::swap<T>(tmp);
			} else {
				*object = tmp;
			}
			*buffer += sizeof(T);
			return HasReturnvaluesIF::RETURN_OK;
		} else {
			return SerializeIF::STREAM_TOO_SHORT;
		}
	}

We can just use size_t like discussed for deSerialize. Example AutoSerializeAdapter: ```cpp ReturnValue_t deSerialize(T* object, const uint8_t** buffer, size_t* size, bool bigEndian) { T tmp; if (*size >= sizeof(T)) { *size -= sizeof(T); memcpy(&tmp, *buffer, sizeof(T)); if (bigEndian) { *object = EndianSwapper::swap<T>(tmp); } else { *object = tmp; } *buffer += sizeof(T); return HasReturnvaluesIF::RETURN_OK; } else { return SerializeIF::STREAM_TOO_SHORT; } } ```

muellerr referenced this issue

2020-05-04 17:18:52 +02:00

Storagemanager Refactoring #66

muellerr commented

2020-06-24 11:56:11 +02:00

What's the state of this issue?

mohr referenced this issue

2020-07-10 12:30:01 +02:00

Update SerializeAdapter #122

gaisser commented

2020-12-03 18:37:53 +01:00

Most usages are fixed by now. I think we can open issues/pull request for single fixes, because they should be rare now.