fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

serialize changes. #35

Closed
muellerr wants to merge 21 commits from KSat:mueller_Serialization into master
pull from: KSat:mueller_Serialization
merge into: fsfw:master
Conversation 4 Commits 21 Files Changed 50 +510 -302
muellerr commented 2020-04-15 21:13:43 +02:00
Owner
Copy Link
  1. a lot of documentation
  2. size_t introduced for both serialize and serialize. override keyword introduced (adapters remain virtual).
  3. some features which could be useful: initialization of serialfixedarraylistadapter with data.
  4. SerializeAdapter split up in interface file and internal file.
  5. rest of size_t replacements (a lot of them..) will come in separate merge
    request
  6. some formatting (80 column width rule)
  7. Serial Lnked List Adapter: copy ctor and copy assignment explicitely deleted.
1. a lot of documentation 2. size_t introduced for both serialize and serialize. override keyword introduced (adapters remain virtual). 3. some features which could be useful: initialization of serialfixedarraylistadapter with data. 4. SerializeAdapter split up in interface file and internal file. 5. rest of size_t replacements (a lot of them..) will come in separate merge request 6. some formatting (80 column width rule) 7. Serial Lnked List Adapter: copy ctor and copy assignment explicitely deleted.
muellerr commented 2020-04-17 14:08:56 +02:00
Author
Owner
Copy Link

This fixes #33

This fixes #33
muellerr commented 2020-04-18 14:44:19 +02:00
Author
Owner
Copy Link

I will split this request up in multiple smaller ones.

I will split this request up in multiple smaller ones.
muellerr added the
invalid
 label 2020-04-30 22:01:22 +02:00
muellerr added
feature
API Change
 and removed
invalid
 labels 2020-05-04 19:32:20 +02:00
muellerr commented 2020-05-04 19:33:26 +02:00
Author
Owner
Copy Link

I left it as one pull request but I removed some wrong/unneeded stuff
and did all replacement until it compiled again. will perform some testing too and try to compile for Linux too.

I left it as one pull request but I removed some wrong/unneeded stuff and did all replacement until it compiled again. will perform some testing too and try to compile for Linux too.
muellerr reviewed 2020-05-04 19:34:28 +02:00
serialize/SerializeAdapter.h
@ -40,3 +45,2 @@
T tmp;
*size -= sizeof(T);
if (*size >= 0) {
if (*size >= sizeof(T)) {
muellerr commented 2020-05-04 19:34:28 +02:00
Author
Owner
Copy Link

I think this should be the correct implementation: check before decrementing.

I think this should be the correct implementation: check before decrementing.
muellerr commented 2020-07-02 14:35:55 +02:00
Author
Owner
Copy Link

after integrating changes for SerializeIF (new enum), this will propably look very different anyway so I will close this for now.

after integrating changes for SerializeIF (new enum), this will propably look very different anyway so I will close this for now.
muellerr closed this pull request 2020-07-03 16:32:23 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#35
No description provided.
Delete Branch "KSat:mueller_Serialization"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?