QueueMapManager #128

New Issue

2020-07-06T13:52:50+02:00

muellerr commented

2020-07-06 13:52:50 +02:00

During a meeting, me and @gaisser were talking about message queues
and the problem that the message queue ID actually breaks layering.

I implemented a QueueMapManager for the host OSAL which is interesting for the FSFW in general because it propably breaks this layering if it is used by the MessageQueue implementations.

THe map manager implements the mapping from MessageQueueId to a message queue pointer.

This could be used to break this layering. CUrrently, the queue map manager uses a std::unordered_map, which in turns uses a hashtable as the underlying data strcture. Therefore, the look-up time would be constant (O(1)) . It is implemented as a singleton. If this is interesting for the FSFW, I will propose a pull request soon.

During a meeting, me and @gaisser were talking about message queues and the problem that the message queue ID actually breaks layering. I implemented a QueueMapManager for the host OSAL which is interesting for the FSFW in general because it propably breaks this layering if it is used by the MessageQueue implementations. THe map manager implements the mapping from MessageQueueId to a message queue pointer. This could be used to break this layering. CUrrently, the queue map manager uses a std::unordered_map, which in turns uses a hashtable as the underlying data strcture. Therefore, the look-up time would be constant (O(1)) . It is implemented as a singleton. If this is interesting for the FSFW, I will propose a pull request soon.

muellerr added the feature label 2020-07-06 13:52:56 +02:00

muellerr commented

2020-07-06 14:01:05 +02:00

Actually, the key propably should be the objectId instead of the message queue ID,
if I read the todo text correctly.
However, that change should be trivial, so if youre are interested, I will implement the mapping like that: object_id_t -> MessageQueueIF* . Of course, an object might have multiple message queues..

Actually, the key propably should be the objectId instead of the message queue ID, if I read the todo text correctly. However, that change should be trivial, so if youre are interested, I will implement the mapping like that: `object_id_t -> MessageQueueIF*` . Of course, an object might have multiple message queues..

muellerr added the question label 2020-07-06 14:08:56 +02:00

gaisser commented

2020-10-27 15:04:01 +01:00

Related or even duplicate of #205

gaisser commented

2020-12-01 15:52:47 +01:00

Close as this is a duplicate of #205

gaisser closed this issue

2020-12-01 15:52:48 +01:00

gaisser added the duplicate label 2020-12-01 15:58:48 +01:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#128