fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Change MessageQueueId to handle that internally #205

New Issue
Closed
opened 2020-09-22 15:54:15 +02:00 by gaisser · 1 comment
gaisser commented 2020-09-22 15:54:15 +02:00
Owner
Copy Link

The current FreeRTOS Version uses a QueueHandle_t pointer to handles its queues, but the FSFW does only support Numeric Queue Identifiers. This is handle by a dirty hack which casts the QueueHandle_t to a void pointer which is 32 bit on a 32 Bit System but brakes on any others.

To fix that, the FSFW should use a map internally to handle the conversion of numeric to OSAL Type.

The current FreeRTOS Version uses a QueueHandle_t pointer to handles its queues, but the FSFW does only support Numeric Queue Identifiers. This is handle by a dirty hack which casts the QueueHandle_t to a void pointer which is 32 bit on a 32 Bit System but brakes on any others. To fix that, the FSFW should use a map internally to handle the conversion of numeric to OSAL Type.
gaisser added the
feature
 label 2020-09-22 15:54:15 +02:00
gaisser added this to the ASTP 1.0.0 Local pools milestone 2020-12-01 15:56:44 +01:00
gaisser commented 2021-04-20 18:00:52 +02:00
Author
Owner
Copy Link

Currently, I would prefer a internal solution of the OSAL like the current Host OSAL:

osal/host/MessageQueue.cpp Line 11 in c50796b785
auto result = QueueMapManager::instance()->addMessageQueue(this, &mqId);

Therefore, this only relevant for FreeRTOS.

Currently, I would prefer a internal solution of the OSAL like the current Host OSAL: https://egit.irs.uni-stuttgart.de/fsfw/fsfw/src/commit/c50796b785cbed04a0b30937f94870f5c2d28f52/osal/host/MessageQueue.cpp#L11 Therefore, this only relevant for FreeRTOS.
gaisser modified the milestone from ASTP 1.0.0 Local pools to ASTP 1.1.0 2021-04-20 18:14:01 +02:00
muellerr was assigned by gaisser 2021-05-11 14:46:01 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
ASTP 1.1.0
Assignees
Clear assignees
No Assignees
muellerr
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#205
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?