fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

DLE encoder doc added #177

Merged
gaisser merged 10 commits from KSat/fsfw:mueller/dledoc into master 2020-09-15 15:01:10 +02:00
Conversation 0 Commits 10 Files Changed 3 +165 -81
muellerr commented 2020-08-26 17:44:39 +02:00
Owner
Copy Link

DLE was successfully integrated in SOURCE as the first transport layer for RS232 communication.
I added some documentation.

DLE was successfully integrated in SOURCE as the first transport layer for RS232 communication. I added some documentation.
muellerr added the
Documentation
 label 2020-08-26 17:44:39 +02:00
gaisser reviewed 2020-08-26 20:01:29 +02:00
globalfunctions/DleEncoder.h
@ -12,3 +33,1 @@
static const uint8_t STX = 0x02;
static const uint8_t ETX = 0x03;
static const uint8_t DLE = 0x10;
static constexpr uint8_t INTERFACE_ID = CLASS_ID::DLE_ENCODER;
gaisser commented 2020-08-26 20:01:28 +02:00
Owner
Copy Link

The CLASS_ID::DLE_ENCODER is not part of this pull request. Am I missing something here?

The CLASS_ID::DLE_ENCODER is not part of this pull request. Am I missing something here?
muellerr commented 2020-08-26 21:27:11 +02:00
Author
Owner
Copy Link

Ah, you're not, I introduced return values. I will also supply the updated class ID list

Ah, you're not, I introduced return values. I will also supply the updated class ID list
gaisser marked this conversation as resolved
gaisser self-assigned this 2020-08-26 20:01:48 +02:00
muellerr changed title from DLE encoder doc added to WIP: DLE encoder doc added 2020-08-26 21:27:18 +02:00
muellerr changed title from WIP: DLE encoder doc added to DLE encoder doc added 2020-09-04 16:54:18 +02:00
gaisser reviewed 2020-09-08 14:31:06 +02:00
returnvalues/FwClassIds.h Outdated
@ -67,0 +67,4 @@
DLE_ENCODER, //DLEE 61
PUS_PARSER, //PUSP 62
SERIAL_ANALYZER, //SERA 63
PUS_SERVICE_9, // PUS9 64
gaisser commented 2020-09-08 14:31:06 +02:00
Owner
Copy Link

What are those additional Ids?

What are those additional Ids?
gaisser merged commit 4c17ef7be5 into master 2020-09-15 15:01:07 +02:00
gaisser deleted branch mueller/dledoc 2020-09-15 15:01:11 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
gaisser
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#177
No description provided.
Delete Branch "KSat/fsfw:mueller/dledoc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?