fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

device handler uses local pools now #299

Merged
gaisser merged 8 commits from KSat/fsfw:mueller/DeviceHandler-LocalPools into development 2020-12-10 17:22:55 +01:00
Conversation 0 Commits 8 Files Changed 2 +194 -124
muellerr commented 2020-12-08 16:02:08 +01:00
Owner
Copy Link

Also added function to get pending command but I need to test that function.

fixes #253 .

Also added function to get pending command but I need to test that function. fixes #253 .
muellerr added the
feature
 label 2020-12-08 16:02:08 +01:00
muellerr added 2 commits 2020-12-08 16:02:09 +01:00
gaisser reviewed 2020-12-08 16:14:48 +01:00
devicehandlers/DeviceHandlerBase.h
@ -942,1 +964,3 @@
* which are set periodically during any normal mode.
* @brief Set all datapool variables that are update periodically in
* normal mode invalid
* @details TODO: Use local pools
gaisser commented 2020-12-08 16:14:48 +01:00
Owner
Copy Link

TODO still valid?

TODO still valid?
muellerr commented 2020-12-08 16:45:50 +01:00
Author
Owner
Copy Link

Yes

Yes
gaisser marked this conversation as resolved
gaisser reviewed 2020-12-09 10:05:57 +01:00
devicehandlers/DeviceHandlerBase.h
@ -738,0 +748,4 @@
* like SPI sensors to identify the last sent command.
* @return
*/
DeviceCommandId_t getPendingCommand() const;
gaisser commented 2020-12-09 10:05:57 +01:00
Owner
Copy Link

This returns the first pending command only. This should be added to the comment.

This returns the first pending command only. This should be added to the comment.
gaisser marked this conversation as resolved
gaisser added this to the ASTP 1.0.0 Local pools milestone 2020-12-09 10:07:01 +01:00
gaisser added 1 commit 2020-12-10 16:57:26 +01:00
gaisser added 1 commit 2020-12-10 17:00:53 +01:00
gaisser added 1 commit 2020-12-10 17:10:47 +01:00
muellerr added 2 commits 2020-12-10 17:19:03 +01:00
gaisser added 1 commit 2020-12-10 17:22:48 +01:00
gaisser merged commit 000129172a into development 2020-12-10 17:22:55 +01:00
gaisser deleted branch mueller/DeviceHandler-LocalPools 2020-12-10 17:23:01 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
ASTP 1.0.0 Local pools
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#299
No description provided.
Delete Branch "KSat/fsfw:mueller/DeviceHandler-LocalPools"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?