fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

device handler uses local pools now #299

Merged
gaisser merged 8 commits from KSat/fsfw:mueller/DeviceHandler-LocalPools into development 2020-12-10 17:22:55 +01:00
Conversation 2 Commits 8 Files Changed 2 +194 -124
muellerr commented 2020-12-08 16:02:08 +01:00
Owner
Copy Link

Also added function to get pending command but I need to test that function.

fixes #253 .

Also added function to get pending command but I need to test that function. fixes #253 .
muellerr added the feature label 2020-12-08 16:02:08 +01:00
muellerr added 2 commits 2020-12-08 16:02:09 +01:00
device handler uses local pools now 5e2e18ac07
tab changed 46596f9397
gaisser reviewed 2020-12-08 16:14:48 +01:00
devicehandlers/DeviceHandlerBase.h
@@ -942,1 +964,3 @@
* which are set periodically during any normal mode.
* @brief Set all datapool variables that are update periodically in
* normal mode invalid
* @details TODO: Use local pools
gaisser commented 2020-12-08 16:14:48 +01:00
Owner
Copy Link

TODO still valid?

TODO still valid?
muellerr commented 2020-12-08 16:45:50 +01:00
Author
Owner
Copy Link

Yes

Yes
gaisser marked this conversation as resolved
gaisser reviewed 2020-12-09 10:05:57 +01:00
devicehandlers/DeviceHandlerBase.h
@@ -738,0 +748,4 @@
* like SPI sensors to identify the last sent command.
* @return
*/
DeviceCommandId_t getPendingCommand() const;
gaisser commented 2020-12-09 10:05:57 +01:00
Owner
Copy Link

This returns the first pending command only. This should be added to the comment.

This returns the first pending command only. This should be added to the comment.
gaisser marked this conversation as resolved
gaisser added this to the ASTP 1.0.0 Local pools milestone 2020-12-09 10:07:01 +01:00
gaisser added 1 commit 2020-12-10 16:57:26 +01:00
Merge branch 'development' into mueller/DeviceHandler-LocalPools f0380e4acc
gaisser added 1 commit 2020-12-10 17:00:53 +01:00
Merge branch 'development' into mueller/DeviceHandler-LocalPools 3fd18f9c58
gaisser added 1 commit 2020-12-10 17:10:47 +01:00
Merge branch 'development' into mueller/DeviceHandler-LocalPools b8f4cfe953
muellerr added 2 commits 2020-12-10 17:19:03 +01:00
updated comment 7986584d17
Merge branch 'mueller/DeviceHandler-LocalPools' of https://egit.irs.uni-stuttgart.de/KSat/fsfw into mueller/DeviceHandler-LocalPools 0cf9f334cc
gaisser added 1 commit 2020-12-10 17:22:48 +01:00
Merge branch 'development' into mueller/DeviceHandler-LocalPools 45b02083c9
gaisser merged commit 000129172a into development 2020-12-10 17:22:55 +01:00
gaisser deleted branch mueller/DeviceHandler-LocalPools 2020-12-10 17:23:01 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
gaisser
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
 Breaking API Change
Changes the API in a non backwards compatible way
 bug
Something is not working
 build
Issues related to the buildsystem, including CI
 cosmetics
Small change most users won't notice
 Documentation
Improvement of code documentation
 duplicate
This issue or pull request already exists
 feature
New feature
 help wanted
Need some help
 hotfix
Quick or important fix that is merged directly into master, causing a new revision
 invalid
#worksforme
 question
More information is needed
 Refactor
Contains a refactoring of some code
 Tests
Issues related to testing code
 wontfix
This won't be fixed
No Label feature
Milestone
No items
No Milestone ASTP 1.0.0 Local pools
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#299
Delete Branch "KSat/fsfw:mueller/DeviceHandler-LocalPools"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?