Rename RAII classes to <Name>Guard #376

New Issue

muellerr · 2021-03-02T17:35:42+01:00

muellerr commented

2021-03-02 17:35:42 +01:00

I started naming RAII classes [Name]Helper, but that name is too generic. What does it help with?

I suggest to rename all RAII classes to [Name]Guard instead and be consistent here. Would also be in line with common C++ naming conventions.

For example: MutexHelper -> MutexGuard

Actually I think this is the only RAII class in the framework right now. But unfortunately it is used everywhere. But adapting names should be trivial.

I started naming RAII classes [Name]Helper, but that name is too generic. What does it help with? I suggest to rename all RAII classes to [Name]Guard instead and be consistent here. Would also be in line with common C++ naming conventions. For example: MutexHelper -> MutexGuard Actually I think this is the only RAII class in the framework right now. But unfortunately it is used everywhere. But adapting names should be trivial.

muellerr added the

feature

API Change

labels 2021-03-02 17:35:42 +01:00

gaisser commented

2021-03-04 21:12:31 +01:00

Good Idea. This seems more explicit.

gaisser added this to the ASTP 1.0.0 Local pools milestone 2021-03-04 21:12:34 +01:00

muellerr was assigned by gaisser

2021-03-04 21:12:39 +01:00

gaisser referenced a pull request that will close this issue

2021-03-04 21:12:50 +01:00