fsfw/fsfw
fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Update Package #378

Merged
gaisser merged 22 commits from KSat/fsfw:mueller/update-pack into development 2021-03-09 14:16:14 +01:00
Conversation 3 Commits 22 Files Changed 23 +1051 -828
muellerr commented 2021-03-04 16:43:31 +01:00
Owner
Copy Link
  • ActionHelper finish and ActionMessage setCompletionReply now explicitely expects information whether
    to generate a failure or success message, API change added to CHANGELOG.
  • PoolReadHelper renamed to PoolReadGuard
  • ReturnValue_t CCSDSTime::convertFromCcsds(timeval* to, const uint8_t* from, size_t* foundLength, size_t maxLength) can now process ASCII strings as well
  • Provides high-level documentation for the local pools in the doc folder
  • Increased exception safety for local pool object classes by introducing more nullptr checks
- ActionHelper `finish` and ActionMessage `setCompletionReply` now explicitely expects information whether to generate a failure or success message, API change added to CHANGELOG. - `PoolReadHelper` renamed to `PoolReadGuard` - `ReturnValue_t CCSDSTime::convertFromCcsds(timeval* to, const uint8_t* from, size_t* foundLength, size_t maxLength)` can now process ASCII strings as well - Provides high-level documentation for the local pools in the `doc` folder - Increased exception safety for local pool object classes by introducing more nullptr checks
muellerr added the
feature
API Change
 labels 2021-03-04 16:43:31 +01:00
muellerr added 7 commits 2021-03-04 16:43:32 +01:00
muellerr added 1 commit 2021-03-04 16:44:29 +01:00
muellerr added 1 commit 2021-03-04 16:45:44 +01:00
muellerr added 1 commit 2021-03-04 16:46:47 +01:00
muellerr added 1 commit 2021-03-04 16:48:30 +01:00
muellerr added 2 commits 2021-03-04 17:46:54 +01:00
muellerr added 6 commits 2021-03-04 18:14:54 +01:00
muellerr added 3 commits 2021-03-04 18:45:56 +01:00
gaisser reviewed 2021-03-04 20:57:42 +01:00
action/ActionMessage.h
@ -36,3 +39,3 @@
static void setDataReply(CommandMessage* message, ActionId_t actionId,
store_address_t data);
static void setCompletionReply(CommandMessage* message, ActionId_t fid,
static void setCompletionReply(bool success, CommandMessage* message, ActionId_t fid,
gaisser commented 2021-03-04 20:57:42 +01:00
Owner
Copy Link

Good Idea. But it might look more consistent if the bool is the last parameter.

Good Idea. But it might look more consistent if the bool is the last parameter.
muellerr commented 2021-03-05 10:05:50 +01:00
Author
Owner
Copy Link

Solved in #380 follow up

Solved in #380 follow up
gaisser self-assigned this 2021-03-04 21:00:42 +01:00
gaisser added this to the ASTP 1.0.0 Local pools milestone 2021-03-04 21:00:44 +01:00
gaisser commented 2021-03-04 21:12:50 +01:00
Owner
Copy Link

Fixes #376

Fixes #376
gaisser commented 2021-03-04 21:13:10 +01:00
Owner
Copy Link

Implements #377

Implements #377
gaisser merged commit dbda6fee82 into development 2021-03-09 14:16:14 +01:00
gaisser deleted branch mueller/update-pack 2021-03-09 15:38:26 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
API Change
feature
Milestone
No items
No Milestone ASTP 1.0.0 Local pools
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees gaisser
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#378
No description provided.
Delete Branch "KSat/fsfw:mueller/update-pack"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?