fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

proper MQ implementation #401

Merged
gaisser merged 2 commits from mueller/host-osal-vector-mq into development 2021-04-20 14:36:48 +02:00
Conversation 2 Commits 2 Files Changed 2 +11 -20
muellerr commented 2021-04-12 12:40:17 +02:00
Owner
Copy Link

This implementation now allows variable message types and is not hardcoded to the MessageQueueMessage

This implementation now allows variable message types and is not hardcoded to the `MessageQueueMessage`
muellerr added the
feature
 label 2021-04-12 12:40:17 +02:00
muellerr added 1 commit 2021-04-12 12:40:18 +02:00
proper MQ implementation 547538fbc5
muellerr added this to the ASTP 1.0.0 Local pools milestone 2021-04-12 12:45:58 +02:00
gaisser added 1 commit 2021-04-13 14:32:21 +02:00
Merge branch 'development' into mueller/host-osal-vector-mq 4479a2628d
gaisser reviewed 2021-04-20 11:32:11 +02:00
osal/host/MessageQueue.cpp
@ -128,21 +130,10 @@ ReturnValue_t MessageQueue::sendMessageFromMessageQueue(MessageQueueId_t sendTo,
return HasReturnvaluesIF::RETURN_FAILED;
gaisser commented 2021-04-20 11:32:11 +02:00
Owner
Copy Link

With a resizing container underneath, this might become a problem. As this is a important config error (even for host systems) this should try to print an error.

With a resizing container underneath, this might become a problem. As this is a important config error (even for host systems) this should try to print an error.
gaisser reviewed 2021-04-20 11:33:38 +02:00
osal/host/MessageQueue.cpp
@ -81,3 +80,3 @@
*count = messageQueue.size();
// Clears the queue.
messageQueue = std::queue<MessageQueueMessage>();
messageQueue = std::queue<std::vector<uint8_t>>();
gaisser commented 2021-04-20 11:33:38 +02:00
Owner
Copy Link

I can't see any use for different messages sizes for now. Actual I think the disadvantages prevail here (config errors, difference between Host system and RTOS, more complex handling in handlers for different messages sizes). It makes everything more complicated for a problem that has been solved already with the IPC Store.

I can't see any use for different messages sizes for now. Actual I think the disadvantages prevail here (config errors, difference between Host system and RTOS, more complex handling in handlers for different messages sizes). It makes everything more complicated for a problem that has been solved already with the IPC Store.
gaisser self-assigned this 2021-04-20 14:36:42 +02:00
gaisser merged commit ea8d887a6b into development 2021-04-20 14:36:48 +02:00
gaisser deleted branch mueller/host-osal-vector-mq 2021-04-20 14:36:52 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
feature
Milestone
No items
No Milestone ASTP 1.0.0 Local pools
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees gaisser
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#401
No description provided.
Delete Branch "mueller/host-osal-vector-mq"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?