proper MQ implementation #401

muellerr · 2021-04-12T12:40:17+02:00

muellerr commented

2021-04-12 12:40:17 +02:00

This implementation now allows variable message types and is not hardcoded to the MessageQueueMessage

This implementation now allows variable message types and is not hardcoded to the `MessageQueueMessage`

muellerr added the

feature

label 2021-04-12 12:40:17 +02:00

muellerr added 1 commit 2021-04-12 12:40:18 +02:00

proper MQ implementation 547538fbc5

muellerr added this to the ASTP 1.0.0 Local pools milestone 2021-04-12 12:45:58 +02:00

gaisser added 1 commit 2021-04-13 14:32:21 +02:00

Merge branch 'development' into mueller/host-osal-vector-mq 4479a2628d

gaisser reviewed 2021-04-20 11:32:11 +02:00

osal/host/MessageQueue.cpp

						
				@ -128,21 +130,10 @@ ReturnValue_t MessageQueue::sendMessageFromMessageQueue(MessageQueueId_t sendTo,

						return HasReturnvaluesIF::RETURN_FAILED;

gaisser commented

2021-04-20 11:32:11 +02:00

With a resizing container underneath, this might become a problem. As this is a important config error (even for host systems) this should try to print an error.

gaisser reviewed 2021-04-20 11:33:38 +02:00

osal/host/MessageQueue.cpp

						
				@ -81,3 +80,3 @@

					*count = messageQueue.size();

					// Clears the queue.

					messageQueue = std::queue<MessageQueueMessage>();

					messageQueue = std::queue<std::vector<uint8_t>>();

gaisser commented

2021-04-20 11:33:38 +02:00

I can't see any use for different messages sizes for now. Actual I think the disadvantages prevail here (config errors, difference between Host system and RTOS, more complex handling in handlers for different messages sizes). It makes everything more complicated for a problem that has been solved already with the IPC Store.