fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Some changes and improvements for DHB #474

Merged
mohr merged 1 commits from eive/fsfw:mueller/dhb-improvements into development 2021-09-20 15:23:24 +02:00
Conversation 1 Commits 1 Files Changed 2 +36 -26
muellerr commented 2021-09-15 17:11:36 +02:00
Owner
Copy Link

How to update to this PR

  1. Rename getCommanderId uses to getCommanderQueueId

Changes

  1. Renamed getCommanderId to getCommanderQueueId. I don't think there are a lot of users of this function and the new name better ressembles the intent of the function
  2. Some indentation
  3. Correct preprocessor define for warning printout used now
  4. Prinout for common configuration error with command missing in command (and reply) map
### How to update to this PR 1. Rename `getCommanderId` uses to `getCommanderQueueId` ### Changes 1. Renamed `getCommanderId` to `getCommanderQueueId`. I don't think there are a lot of users of this function and the new name better ressembles the intent of the function 2. Some indentation 3. Correct preprocessor define for warning printout used now 4. Prinout for common configuration error with command missing in command (and reply) map
muellerr added 1 commit 2021-09-15 17:11:37 +02:00
Some changes and improvements for DHB 21b5eaa891 
1. Renamed getCommanderId to getCommanderQueueId.
2. Some indentation
3. Correct preprocessor define for warning printout used now
muellerr requested review from mohr 2021-09-15 17:11:47 +02:00
muellerr added the
Breaking API Change
 label 2021-09-15 17:12:39 +02:00
mohr approved these changes 2021-09-20 15:23:19 +02:00
mohr merged commit 39c909946b into development 2021-09-20 15:23:24 +02:00
muellerr deleted branch mueller/dhb-improvements 2021-09-20 15:25:48 +02:00
gaisser added this to the v2.0.0 milestone 2021-09-27 15:03:12 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
mohr
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
Breaking API Change
Milestone
No items
No Milestone v2.0.0
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#474
No description provided.
Delete Branch "eive/fsfw:mueller/dhb-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?