fsfw/fsfw
12
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

DHB improvements, possible bug #472

Closed
muellerr wants to merge 5 commits from eive/fsfw:mueller/dhb-bugfixes-improvements into development
pull from: eive/fsfw:mueller/dhb-bugfixes-improvements
merge into: :development
Conversation 3 Commits 5 Files Changed 4
+27 -12
muellerr commented 2021-09-08 16:18:34 +02:00
Owner
Copy Link
Copy Source

I found it a bit confusing after using DHB again after a long time how external commanding and the generation of verification messages is handled. These changes clarify the behaviour of DHB for external commanding a bit.

Additional diagnostic output for invalid commands was added as well.

Also, Iam not sure whether this is a bug, but a FDIR event will be trigged if getSendSuccess returns NO_REPLY_EXPECTED

I found it a bit confusing after using DHB again after a long time how external commanding and the generation of verification messages is handled. These changes clarify the behaviour of DHB for external commanding a bit. Additional diagnostic output for invalid commands was added as well. Also, Iam not sure whether this is a bug, but a FDIR event will be trigged if `getSendSuccess` returns `NO_REPLY_EXPECTED`
muellerr added 1 commit 2021-09-08 16:18:34 +02:00
DHB improvements dfe49cc1e5
muellerr added the Documentationfeature labels 2021-09-08 16:19:21 +02:00
muellerr changed title from DHB improvements to DHB improvements, possible bug 2021-09-08 16:20:00 +02:00
muellerr added 1 commit 2021-09-08 16:20:07 +02:00
Merge branch 'development' into mueller/dhb-bugfixes-improvements 6b20bb197a
muellerr added 1 commit 2021-09-11 17:45:09 +02:00
Merge branch 'development' into mueller/dhb-bugfixes-improvements 02d78413e8
mohr commented 2021-09-13 11:00:40 +02:00
Owner
Copy Link
Copy Source

I think there is a misunderstanding here:
NO_REPLY_EXPECTED is not returned by getSendSuccess() but by enableReplyInReplyMap(). Thus, it will not trigger an FDIR event as it is returned in the if branch, while the check is located in the else path.
result == NO_REPLY_EXPECTED is handled correctly in replyToCommand().

I think there is a misunderstanding here: `NO_REPLY_EXPECTED` is not returned by `getSendSuccess()` but by `enableReplyInReplyMap()`. Thus, it will not trigger an FDIR event as it is returned in the `if` branch, while the check is located in the `else` path. `result == NO_REPLY_EXPECTED` is handled correctly in `replyToCommand()`.
muellerr added 1 commit 2021-09-13 14:54:00 +02:00
Merge branch 'development' into mueller/dhb-bugfixes-improvements 9b05349991
muellerr commented 2021-09-13 15:09:51 +02:00
Author
Owner
Copy Link
Copy Source

OKay, I'll check this

OKay, I'll check this
muellerr added 1 commit 2021-09-15 17:12:02 +02:00
Merge branch 'development' into mueller/dhb-bugfixes-improvements 6f6738ec01
mohr commented 2021-09-20 15:26:06 +02:00
Owner
Copy Link
Copy Source

#474 fixes actual problem, remaining is the misunderstanding (#wontfix) and a possible bug in eive FSW which needs to be confirmed.

#474 fixes actual problem, remaining is the misunderstanding (#wontfix) and a possible bug in eive FSW which needs to be confirmed.
mohr closed this pull request 2021-09-20 15:26:06 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
 Breaking API Change
Changes the API in a non backwards compatible way
 bug
Something is not working
 build
Issues related to the buildsystem, including CI
 cosmetics
Small change most users won't notice
 Documentation
Improvement of code documentation
 duplicate
This issue or pull request already exists
 feature
New feature
 help wanted
Need some help
 hotfix
Quick or important fix that is merged directly into master, causing a new revision
 invalid
#worksforme
 question
More information is needed
 Refactor
Contains a refactoring of some code
 Tests
Issues related to testing code
 wontfix
This won't be fixed
No labels Documentation feature
Milestone
No items
No Milestone
Assignees
Clear assignees
ahinkel (Andy Hinkel) gaisser (Steffen Gaisser) jenkins_buildfix meierj (Jakob Meier) mohr (Ulrich Mohr) mspahr muellerr (Robin Müller) tbaumgartl (Tobias Baumgartl)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#472