fsfw/fsfw
12
3 Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

SP reader getPacketData is const now #708

Merged
gaisser merged 2 commits from eive/fsfw:mueller/sp_reader_const_get_data into development 2022-11-21 15:23:45 +01:00
Conversation 1 Commits 2 Files Changed 2
+2 -2
muellerr commented 2022-11-15 10:48:04 +01:00
Owner
Copy link
Copy source
No description provided.
muellerr added 1 commit 2022-11-15 10:48:07 +01:00
SP reader getPacketData is const now
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
2a842666d5
muellerr added this to the v6.0.0 milestone 2022-11-15 10:48:15 +01:00
muellerr requested review from gaisser 2022-11-15 10:48:20 +01:00
gaisser approved these changes 2022-11-21 14:50:38 +01:00
gaisser left a comment
Owner
Copy link
Copy source

LGTM

LGTM
gaisser added 1 commit 2022-11-21 14:50:51 +01:00
Merge branch 'development' into mueller/sp_reader_const_get_data
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
0129783e34
gaisser merged commit d699d16307 into development 2022-11-21 15:23:41 +01:00
gaisser deleted branch mueller/sp_reader_const_get_data 2022-11-21 15:23:47 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
gaisser
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
 Breaking API Change
Changes the API in a non backwards compatible way
 Documentation
Improvement of code documentation
 Refactor
Contains a refactoring of some code
 Tests
Issues related to testing code
 bug
Something is not working
 build
Issues related to the buildsystem, including CI
 cosmetics
Small change most users won't notice
 duplicate
This issue or pull request already exists
 feature
New feature
 help wanted
Need some help
 hotfix
Quick or important fix that is merged directly into master, causing a new revision
 invalid
#worksforme
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone v6.0.0
Assignees
Clear assignees
ahinkel (Andy Hinkel) gaisser (Steffen Gaisser) jenkins_buildfix meierj (Jakob Meier) mohr (Ulrich Mohr) mspahr muellerr (Robin Müller) tbaumgartl (Tobias Baumgartl)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#708