fsfw/fsfw
12
3 Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

CMakeLists file updates #731

Merged
mohr merged 4 commits from eive/fsfw:cmakelists_update into development 2023-02-09 15:29:47 +01:00
Conversation 5 Commits 4 Files Changed 2
+8 -5
muellerr commented 2023-02-07 12:16:02 +01:00
Owner
Copy link
Copy source
  • Suppress warning if ETL is not found because then we do an auto-download and the warning is confusing.
  • Correction and improvement for printout in other CMakeLists.txt file.
- Suppress warning if ETL is not found because then we do an auto-download and the warning is confusing. - Correction and improvement for printout in other `CMakeLists.txt` file.
muellerr added 1 commit 2023-02-07 12:16:05 +01:00
correction for printout, add prefix
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
0a23f2c85a
muellerr added 1 commit 2023-02-07 12:16:46 +01:00
suppress error if ETL is not found
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
539d7aac9e
muellerr changed title from correction for printout, add prefix to CMakeLists file updates 2023-02-07 12:17:00 +01:00
muellerr added this to the v6.0.0 milestone 2023-02-07 12:17:59 +01:00
muellerr requested review from gaisser 2023-02-07 12:18:05 +01:00
mohr added 1 commit 2023-02-09 11:35:25 +01:00
Making fetch Catch2 quiet as well.
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
8c712441ab
mohr commented 2023-02-09 11:37:27 +01:00
Owner
Copy link
Copy source

I made the fetch of Catch2 quiet as well and unified the messages when ETL or Catch2 are not found. The one for ETL was misleading as it said "installing".

As for the addition of CONFIG, I do not see how this affects the verbosity of the command. It only changes the way find_package searches for the package and I am not sure we want to restrict it to config mode only.

I made the fetch of Catch2 quiet as well and unified the messages when ETL or Catch2 are not found. The one for ETL was misleading as it said "installing". As for the addition of `CONFIG`, I do not see how this affects the verbosity of the command. It only changes the way find_package searches for the package and I am not sure we want to restrict it to config mode only.
muellerr commented 2023-02-09 13:47:27 +01:00
Author
Owner
Copy link
Copy source

CONFIG not necessary, probably something I forgot to remove. Did you do this in another branch?

`CONFIG` not necessary, probably something I forgot to remove. Did you do this in another branch?
mohr added 1 commit 2023-02-09 13:50:20 +01:00
removed unneeded find_package parameter for etl
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
010509efb4
mohr commented 2023-02-09 13:50:47 +01:00
Owner
Copy link
Copy source

Ok, I removed CONFIG. Did I do what in another branch?

Ok, I removed `CONFIG`. Did I do what in another branch?
muellerr commented 2023-02-09 14:55:00 +01:00
Author
Owner
Copy link
Copy source

Ah you pushed into this branch directly no issues.

Ah you pushed into this branch directly no issues.
mohr removed review request for gaisser 2023-02-09 15:27:36 +01:00
mohr approved these changes 2023-02-09 15:27:44 +01:00
mohr merged commit b676040c7c into development 2023-02-09 15:29:47 +01:00
muellerr deleted branch cmakelists_update 2023-02-09 18:05:08 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
mohr
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
 Breaking API Change
Changes the API in a non backwards compatible way
 Documentation
Improvement of code documentation
 Refactor
Contains a refactoring of some code
 Tests
Issues related to testing code
 bug
Something is not working
 build
Issues related to the buildsystem, including CI
 cosmetics
Small change most users won't notice
 duplicate
This issue or pull request already exists
 feature
New feature
 help wanted
Need some help
 hotfix
Quick or important fix that is merged directly into master, causing a new revision
 invalid
#worksforme
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone v6.0.0
Assignees
Clear assignees
ahinkel (Andy Hinkel) gaisser (Steffen Gaisser) jenkins_buildfix meierj (Jakob Meier) mohr (Ulrich Mohr) mspahr muellerr (Robin Müller) tbaumgartl (Tobias Baumgartl)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#731