fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

CMakeLists file updates #731

Merged
mohr merged 4 commits from eive/fsfw:cmakelists_update into development 2023-02-09 15:29:47 +01:00
Conversation 4 Commits 4 Files Changed 2 +8 -5
muellerr commented 2023-02-07 12:16:02 +01:00
Owner
Copy Link
  • Suppress warning if ETL is not found because then we do an auto-download and the warning is confusing.
  • Correction and improvement for printout in other CMakeLists.txt file.
- Suppress warning if ETL is not found because then we do an auto-download and the warning is confusing. - Correction and improvement for printout in other `CMakeLists.txt` file.
muellerr added 1 commit 2023-02-07 12:16:05 +01:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
0a23f2c85a
correction for printout, add prefix
muellerr added 1 commit 2023-02-07 12:16:46 +01:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
539d7aac9e
suppress error if ETL is not found
muellerr changed title from correction for printout, add prefix to CMakeLists file updates 2023-02-07 12:17:00 +01:00
muellerr added this to the v6.0.0 milestone 2023-02-07 12:17:59 +01:00
muellerr requested review from gaisser 2023-02-07 12:18:05 +01:00
mohr added 1 commit 2023-02-09 11:35:25 +01:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
8c712441ab Making fetch Catch2 quiet as well.
mohr commented 2023-02-09 11:37:27 +01:00
Owner
Copy Link

I made the fetch of Catch2 quiet as well and unified the messages when ETL or Catch2 are not found. The one for ETL was misleading as it said "installing".

As for the addition of CONFIG, I do not see how this affects the verbosity of the command. It only changes the way find_package searches for the package and I am not sure we want to restrict it to config mode only.

I made the fetch of Catch2 quiet as well and unified the messages when ETL or Catch2 are not found. The one for ETL was misleading as it said "installing". As for the addition of `CONFIG`, I do not see how this affects the verbosity of the command. It only changes the way find_package searches for the package and I am not sure we want to restrict it to config mode only.
muellerr commented 2023-02-09 13:47:27 +01:00
Author
Owner
Copy Link

CONFIG not necessary, probably something I forgot to remove. Did you do this in another branch?

`CONFIG` not necessary, probably something I forgot to remove. Did you do this in another branch?
mohr added 1 commit 2023-02-09 13:50:20 +01:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
010509efb4 removed unneeded find_package parameter for etl
mohr commented 2023-02-09 13:50:47 +01:00
Owner
Copy Link

Ok, I removed CONFIG. Did I do what in another branch?

Ok, I removed `CONFIG`. Did I do what in another branch?
muellerr commented 2023-02-09 14:55:00 +01:00
Author
Owner
Copy Link

Ah you pushed into this branch directly no issues.

Ah you pushed into this branch directly no issues.
mohr removed review request for gaisser 2023-02-09 15:27:36 +01:00
mohr approved these changes 2023-02-09 15:27:44 +01:00
mohr merged commit b676040c7c into development 2023-02-09 15:29:47 +01:00
muellerr deleted branch cmakelists_update 2023-02-09 18:05:08 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
mohr
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v6.0.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#731
No description provided.
Delete Branch "eive/fsfw:cmakelists_update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?