MessageQueueId_t NO_QUEUE = 0 #94

New Issue

2020-06-01T11:27:20+02:00

muellerr commented

2020-06-01 11:27:20 +02:00

The defintion for NO_QUEUE is 0. I' m not sure this is a good idea because the ID is often times created by the OS. Wouldn't it be better to set this to 0xffffffff?

At least a check on the generated queue ID should be performed (MessageQueue ctor) to ensure its always 0 and emmit an error if it is 0 (if 0 isn't the returned value for a failed message queue intiialization of course).

The defintion for NO_QUEUE is 0. I' m not sure this is a good idea because the ID is often times created by the OS. Wouldn't it be better to set this to 0xffffffff? At least a check on the generated queue ID should be performed (MessageQueue ctor) to ensure its always 0 and emmit an error if it is 0 (if 0 isn't the returned value for a failed message queue intiialization of course).

muellerr added the question label 2020-06-01 11:27:20 +02:00

muellerr commented

2020-06-10 18:37:47 +02:00

I changed the value, and it broke parts in the code for FreeRTOS.
This is not ideal. Message Queue Ids in the FSFW were initialized with 0 (magic number..) instead of NO_QUEUE. I think all 0 initializations should be replaced by NO_QUEUE.

I changed the value, and it broke parts in the code for FreeRTOS. This is not ideal. Message Queue Ids in the FSFW were initialized with 0 (magic number..) instead of NO_QUEUE. I think all 0 initializations should be replaced by NO_QUEUE.

muellerr added the bug label 2020-06-10 18:37:52 +02:00

gaisser commented

2020-09-22 15:54:35 +02:00

This will be fixed by #205

gaisser closed this issue

2020-09-22 15:54:35 +02:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#94