fsfw/fsfw
fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Move static constants to DeviceHandlerIF #331

Merged
gaisser merged 3 commits from eive/fsfw:mueller/no-raw-command-moved-to-if into development 2020-12-23 23:51:41 +01:00
Conversation 1 Commits 3 Files Changed 3 +4 -5
muellerr commented 2020-12-23 20:21:43 +01:00
Owner
Copy Link

Not good that these variables already exist, also potential bug because RAW_COMMAND is actually -1 while the define NO_COMMAND is DeviceHandlerIF is also -1. I suggest to move all constants to Device Handler IF.

Not good that these variables already exist, also potential bug because RAW_COMMAND is actually -1 while the define NO_COMMAND is DeviceHandlerIF is also -1. I suggest to move all constants to Device Handler IF.
muellerr added the
feature
API Change
 labels 2020-12-23 20:21:43 +01:00
muellerr added 3 commits 2020-12-23 20:21:44 +01:00
muellerr added the
bug
 label 2020-12-23 20:22:16 +01:00
muellerr changed title from Moved static constants to DeviceHandlerIF to Move static constants to DeviceHandlerIF 2020-12-23 20:29:04 +01:00
gaisser commented 2020-12-23 23:51:33 +01:00
Owner
Copy Link

Great that you found that :)

Great that you found that :)
gaisser merged commit 426514b9a2 into development 2020-12-23 23:51:41 +01:00
gaisser deleted branch mueller/no-raw-command-moved-to-if 2020-12-23 23:51:45 +01:00
gaisser added this to the ASTP 1.0.0 Local pools milestone 2021-01-26 14:27:48 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
API Change
bug
feature
Milestone
No items
No Milestone ASTP 1.0.0 Local pools
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#331
No description provided.
Delete Branch "eive/fsfw:mueller/no-raw-command-moved-to-if"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?