ExtendedController Base and MSVC updates #382

muellerr · 2021-03-08T14:23:36+01:00

muellerr commented

2021-03-08 14:23:36 +01:00

Implements the forwarding of abstract functions to the user on top of #380 for the ExtendedControllerBase. This forces implementing functions to implement those abstract functions (which is better and more explicit), therefore classified API change.

Also includes updates to make the FSFW compilable with MSVC, using Visual Studio 2019 for my tests. Unfortunately, some template forward declarations still cause compiler crashes for the most recent Visual Studio 2019 compilation process, but I think this will be fixed soon. MSVC is (rightfully) allergic to the implicit conversion size_t to smaller datatypes, so there is a ton of warnings. This is a good opportunity to add casts where needed.

Implements the forwarding of abstract functions to the user on top of #380 for the ExtendedControllerBase. This forces implementing functions to implement those abstract functions (which is better and more explicit), therefore classified API change. Also includes updates to make the FSFW compilable with MSVC, using Visual Studio 2019 for my tests. Unfortunately, some template forward declarations still cause compiler crashes for the most recent Visual Studio 2019 compilation process, but I think this will be fixed soon. MSVC is (rightfully) allergic to the implicit conversion size_t to smaller datatypes, so there is a ton of warnings. This is a good opportunity to add casts where needed.

muellerr added 32 commits 2021-03-08 14:23:36 +01:00

success flag not explicitely expected for actions 9a3cd1d7fc

updated clock module 6580aa73bf

form stuff and cleaning up bff8d103ba

Merge branch 'mueller/master' of https://egit.irs.uni-stuttgart.de/KSat/fsfw into mueller/master 041461a066

fixed order d8d18c9333

small form stuff dae4a5fa74

renamed guard class 21a7fd621d

whitespaces instead of tabs d66e486f16

updated changelog 4250c7e022

changelog update bd903b8447

removing whitespaces 043d47e5e4

new functions to set all vars read only 35825a6561

added local pool doc 8de33f1301

improved readme 23873f6bc6

readme update a7878aaf04

updated READMe d84003d62a

added graph 6df1abf570

updated readme 69b428222a

better entry text e0d7363eed

readme typo e501390d7b

another rwadme update a56cf43897

increaed exception safety 227074fd4d

tiny form stuff bc7d956899

small tweak to avoid warning cb514e7493

properly implemented getDataAndTime 2d069896a5

setCompletionReply ActionMessage b3ca7b8667

success flag is now third parameter

formatting correction caa3cf538b

MSVC FSFW almost compiling e7cd7c8dc3

Merge branch 'mueller/master' of https://egit.irs.uni-stuttgart.de/fsfw/fsfw into mueller/master 9efc5dbd61

implemented explicit virt abstract propagation 331bbd14e7

typo 1966b33613

removed obsolete comment bdd66072d1

muellerr added the

feature

API Change

labels 2021-03-08 14:23:47 +01:00

gaisser added 1 commit 2021-03-09 14:19:03 +01:00

Merge branch 'development' into mueller/fsfw-update-3 f5ac4368d8

muellerr added 1 commit 2021-03-09 14:48:52 +01:00

updated power component 59028ccc3f

gaisser reviewed 2021-03-09 15:39:14 +01:00

power/PowerComponent.h Outdated

						
				@ -10,3 +10,3 @@

				class PowerComponent: public PowerComponentIF {

				public:

					PowerComponent(object_id_t setId, uint8_t moduleId, float min, float max,

					PowerComponent(object_id_t setId, uint8_t moduleId, float minVoltage, float maxVoltage,

gaisser commented

2021-03-09 15:39:14 +01:00

Parameter naming is now wrong here

muellerr commented

2021-03-09 21:12:38 +01:00

fixed

muellerr marked this conversation as resolved

gaisser reviewed 2021-03-09 15:39:44 +01:00

datapoollocal/LocalPoolDataSetBase.cpp

						
				@ -100,0 +98,4 @@

				    const uint8_t validityMaskSize = std::ceil(static_cast<float>(fillCount)/8.0);

				    /* Use a std::vector here because MSVC will (rightly) not create a fixed size array

				    with a non constant size specifier */

				    std::vector<uint8_t> validityMask(validityMaskSize);