ExtendedController Base and MSVC updates #382

muellerr · 2021-03-08T14:23:36+01:00

muellerr commented

2021-03-08 14:23:36 +01:00

Implements the forwarding of abstract functions to the user on top of #380 for the ExtendedControllerBase. This forces implementing functions to implement those abstract functions (which is better and more explicit), therefore classified API change.

Also includes updates to make the FSFW compilable with MSVC, using Visual Studio 2019 for my tests. Unfortunately, some template forward declarations still cause compiler crashes for the most recent Visual Studio 2019 compilation process, but I think this will be fixed soon. MSVC is (rightfully) allergic to the implicit conversion size_t to smaller datatypes, so there is a ton of warnings. This is a good opportunity to add casts where needed.

Implements the forwarding of abstract functions to the user on top of #380 for the ExtendedControllerBase. This forces implementing functions to implement those abstract functions (which is better and more explicit), therefore classified API change. Also includes updates to make the FSFW compilable with MSVC, using Visual Studio 2019 for my tests. Unfortunately, some template forward declarations still cause compiler crashes for the most recent Visual Studio 2019 compilation process, but I think this will be fixed soon. MSVC is (rightfully) allergic to the implicit conversion size_t to smaller datatypes, so there is a ton of warnings. This is a good opportunity to add casts where needed.

muellerr added 32 commits 2021-03-08 14:23:36 +01:00

9a3cd1d7fc success flag not explicitely expected for actions

6580aa73bf updated clock module

bff8d103ba form stuff and cleaning up

041461a066 Merge branch 'mueller/master' of https://egit.irs.uni-stuttgart.de/KSat/fsfw into mueller/master

d8d18c9333 fixed order

dae4a5fa74 small form stuff

21a7fd621d renamed guard class

d66e486f16 whitespaces instead of tabs

4250c7e022 updated changelog

bd903b8447 changelog update

043d47e5e4 removing whitespaces

35825a6561 new functions to set all vars read only

8de33f1301 added local pool doc

23873f6bc6 improved readme

a7878aaf04 readme update

d84003d62a updated READMe

6df1abf570 added graph

69b428222a updated readme

e0d7363eed better entry text

e501390d7b readme typo

a56cf43897 another rwadme update

227074fd4d increaed exception safety

bc7d956899 tiny form stuff

cb514e7493 small tweak to avoid warning

2d069896a5 properly implemented getDataAndTime

b3ca7b8667 setCompletionReply ActionMessage

success flag is now third parameter

caa3cf538b formatting correction

e7cd7c8dc3 MSVC FSFW almost compiling

9efc5dbd61 Merge branch 'mueller/master' of https://egit.irs.uni-stuttgart.de/fsfw/fsfw into mueller/master

331bbd14e7 implemented explicit virt abstract propagation

1966b33613 typo

bdd66072d1 removed obsolete comment

muellerr added the

feature

API Change

labels 2021-03-08 14:23:47 +01:00

gaisser added 1 commit 2021-03-09 14:19:03 +01:00

f5ac4368d8 Merge branch 'development' into mueller/fsfw-update-3

muellerr added 1 commit 2021-03-09 14:48:52 +01:00

59028ccc3f updated power component

gaisser reviewed 2021-03-09 15:39:14 +01:00

power/PowerComponent.h Outdated

						
				@ -10,3 +10,3 @@

				class PowerComponent: public PowerComponentIF {

				public:

					PowerComponent(object_id_t setId, uint8_t moduleId, float min, float max,

					PowerComponent(object_id_t setId, uint8_t moduleId, float minVoltage, float maxVoltage,

gaisser commented

2021-03-09 15:39:14 +01:00

Parameter naming is now wrong here

muellerr commented

2021-03-09 21:12:38 +01:00

fixed

muellerr marked this conversation as resolved

gaisser reviewed 2021-03-09 15:39:44 +01:00

datapoollocal/LocalPoolDataSetBase.cpp

						
				@ -100,0 +98,4 @@

				    const uint8_t validityMaskSize = std::ceil(static_cast<float>(fillCount)/8.0);

				    /* Use a std::vector here because MSVC will (rightly) not create a fixed size array

				    with a non constant size specifier */

				    std::vector<uint8_t> validityMask(validityMaskSize);