fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

TCP/IP module updates for Linux and Windows #387

Merged
gaisser merged 18 commits from mueller/tcpip-updates into development 2021-03-16 15:19:40 +01:00
Conversation 0 Commits 18 Files Changed 24 +813 -495
muellerr commented 2021-03-12 18:36:24 +01:00
Owner
Copy Link

Refactored TCP/IP code as preparation for TCP code.

  • More conformant to recommended way to set up a server
    by using getaddrinfo instead of setsockopt (see https://en.wikipedia.org/wiki/Getaddrinfo)
  • Possible bugfix for Linux and Windows which explains why replies were not coming back: Sender struct is now assigned completely in the bridge instead of just assigning the address component of the struct
  • Code is also a lot more clean, common code was packaged into separate files and error handling was unified instead of being split across multiple functions. Focus here was to provide developers with immediate printout information about error code, this still has room for improvement
  • Missing mutex lock was added for Windows code.
  • Unused fields removed
  • Windows changes tested on Windows 10, Linux changes tested on a Raspberry Pi
Refactored TCP/IP code as preparation for TCP code. - More conformant to recommended way to set up a server by using `getaddrinfo` instead of `setsockopt` (see https://en.wikipedia.org/wiki/Getaddrinfo) - Possible bugfix for Linux and Windows which explains why replies were not coming back: Sender struct is now assigned completely in the bridge instead of just assigning the address component of the struct - Code is also a lot more clean, common code was packaged into separate files and error handling was unified instead of being split across multiple functions. Focus here was to provide developers with immediate printout information about error code, this still has room for improvement - Missing mutex lock was added for Windows code. - Unused fields removed - Windows changes tested on Windows 10, Linux changes tested on a Raspberry Pi
muellerr added the
bug
feature
 labels 2021-03-12 18:36:24 +01:00
muellerr added 62 commits 2021-03-12 18:36:25 +01:00
muellerr added a new dependency 2021-03-12 18:39:52 +01:00
#386 Local Pool Test Updates
muellerr changed title from TCP IP updates for Linux and Windows to TCP/IP module updates for Linux and Windows 2021-03-12 18:40:29 +01:00
gaisser added this to the ASTP 1.0.0 Local pools milestone 2021-03-16 15:09:36 +01:00
gaisser self-assigned this 2021-03-16 15:09:39 +01:00
gaisser added 1 commit 2021-03-16 15:19:32 +01:00
gaisser merged commit b757c5523c into development 2021-03-16 15:19:40 +01:00
gaisser deleted branch mueller/tcpip-updates 2021-03-16 15:19:45 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
ASTP 1.0.0 Local pools
Assignees
Clear assignees
No Assignees
gaisser
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on
#386 Local Pool Test Updates
fsfw/fsfw
Reference: fsfw/fsfw#387
No description provided.
Delete Branch "mueller/tcpip-updates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?