dhb multiple replies support #416

meierj · 2021-04-25T11:47:27+02:00

meierj commented

2021-04-25 11:47:27 +02:00

Fixes #405
Implemented appraoch 3

Fixes #405 Implemented appraoch 3

meierj added 1 commit 2021-04-25 11:47:28 +02:00

dhb multiple replies support 87fee9bd0e

gaisser reviewed 2021-04-25 22:34:13 +02:00

devicehandlers/DeviceHandlerBase.cpp

						
				@ -309,2 +309,4 @@

				        Clock::getUptime(&currentUptime);

				        if (currentUptime - timeoutStart >= childTransitionDelay) {

				#if FSFW_VERBOSE_LEVEL >= 1

				            char printout[60];

gaisser commented

2021-04-25 22:34:13 +02:00

This information is part of the event below (Line 319), which is printed as debug output as well. Is there a special reason to print it twice?

muellerr commented

2021-04-26 12:17:12 +02:00

It is not printed if FSFW_OBJ_EVENT_TRANSLATION == 0 . I suggest to change
#if FSFW_VERBOSE_LEVEL >= 1 to #if FSFW_VERBOSE_LEVEL >= 1 && FSFW_OBJ_EVENT_TRANSLATION == 0

It is not printed if `FSFW_OBJ_EVENT_TRANSLATION == 0` . I suggest to change `#if FSFW_VERBOSE_LEVEL >= 1` to `#if FSFW_VERBOSE_LEVEL >= 1 && FSFW_OBJ_EVENT_TRANSLATION == 0`

muellerr commented

2021-04-26 12:17:38 +02:00

This is something I wrote and we decided to keep it in there because it's a useful printout

gaisser commented

2021-04-26 15:02:09 +02:00

Ok, than we keep it but I disagree with the comment:

/* Very common configuration error, so print it */

This happens in flight as well if your device does not respond, which happens from time to time for radiation.

It is not printed if FSFW_OBJ_EVENT_TRANSLATION == 0 . I suggest to change
#if FSFW_VERBOSE_LEVEL >= 1 to #if FSFW_VERBOSE_LEVEL >= 1 && FSFW_OBJ_EVENT_TRANSLATION == 0

I think the second one is a good idea. Otherwise you will just spam your console with duplicate information.

Ok, than we keep it but I disagree with the comment: /* Very common configuration error, so print it */ This happens in flight as well if your device does not respond, which happens from time to time for radiation. > It is not printed if `FSFW_OBJ_EVENT_TRANSLATION == 0` . I suggest to change > `#if FSFW_VERBOSE_LEVEL >= 1` to `#if FSFW_VERBOSE_LEVEL >= 1 && FSFW_OBJ_EVENT_TRANSLATION == 0` I think the second one is a good idea. Otherwise you will just spam your console with duplicate information.

gaisser marked this conversation as resolved

muellerr added the

feature

label 2021-04-26 12:21:08 +02:00

gaisser added 1 commit 2021-04-26 16:19:59 +02:00

Merge branch 'development' into meier/multipleRepliesDhb 20e7fe6cb1

gaisser added this to the ASTP 1.0.0 Local pools milestone 2021-04-26 16:26:03 +02:00

gaisser self-assigned this 2021-04-27 14:09:49 +02:00

muellerr added 1 commit 2021-04-27 14:17:41 +02:00

avoid duplicate printout 054de9781b

gaisser approved these changes 2021-04-27 14:18:09 +02:00

gaisser merged commit 9f83739771 into development