fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

dhb multiple replies support #416

Merged
gaisser merged 3 commits from eive/fsfw:meier/multipleRepliesDhb into development 2021-04-27 14:18:15 +02:00
Conversation 0 Commits 3 Files Changed 2 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 054de9781b - Show all commits

4
devicehandlers/DeviceHandlerBase.cpp
View File

@ -308,11 +308,11 @@ void DeviceHandlerBase::doStateMachine() {
uint32_t currentUptime;
Clock::getUptime(&currentUptime);
if (currentUptime - timeoutStart >= childTransitionDelay) {
#if FSFW_VERBOSE_LEVEL >= 1
#if FSFW_VERBOSE_LEVEL >= 1 && FSFW_OBJ_EVENT_TRANSLATION == 0
char printout[60];
gaisser marked this conversation as resolved
gaisser commented 2021-04-25 22:34:13 +02:00
Review
Copy Link

This information is part of the event below (Line 319), which is printed as debug output as well. Is there a special reason to print it twice?

This information is part of the event below (Line 319), which is printed as debug output as well. Is there a special reason to print it twice?
muellerr commented 2021-04-26 12:17:12 +02:00
Review
Copy Link

It is not printed if FSFW_OBJ_EVENT_TRANSLATION == 0 . I suggest to change
#if FSFW_VERBOSE_LEVEL >= 1 to #if FSFW_VERBOSE_LEVEL >= 1 && FSFW_OBJ_EVENT_TRANSLATION == 0

It is not printed if `FSFW_OBJ_EVENT_TRANSLATION == 0` . I suggest to change `#if FSFW_VERBOSE_LEVEL >= 1` to `#if FSFW_VERBOSE_LEVEL >= 1 && FSFW_OBJ_EVENT_TRANSLATION == 0`
muellerr commented 2021-04-26 12:17:38 +02:00
Review
Copy Link

This is something I wrote and we decided to keep it in there because it's a useful printout

This is something I wrote and we decided to keep it in there because it's a useful printout
gaisser commented 2021-04-26 15:02:09 +02:00
Review
Copy Link

Ok, than we keep it but I disagree with the comment:

/* Very common configuration error, so print it */

This happens in flight as well if your device does not respond, which happens from time to time for radiation.

It is not printed if FSFW_OBJ_EVENT_TRANSLATION == 0 . I suggest to change
#if FSFW_VERBOSE_LEVEL >= 1 to #if FSFW_VERBOSE_LEVEL >= 1 && FSFW_OBJ_EVENT_TRANSLATION == 0

I think the second one is a good idea. Otherwise you will just spam your console with duplicate information.

Ok, than we keep it but I disagree with the comment: /* Very common configuration error, so print it */ This happens in flight as well if your device does not respond, which happens from time to time for radiation. > It is not printed if `FSFW_OBJ_EVENT_TRANSLATION == 0` . I suggest to change > `#if FSFW_VERBOSE_LEVEL >= 1` to `#if FSFW_VERBOSE_LEVEL >= 1 && FSFW_OBJ_EVENT_TRANSLATION == 0` I think the second one is a good idea. Otherwise you will just spam your console with duplicate information.
sprintf(printout, "Transition timeout (%lu) occured !",
static_cast<unsigned long>(childTransitionDelay));
/* Very common configuration error, so print it */
/* Common configuration error for development, so print it */
printWarningOrError(sif::OutputTypes::OUT_WARNING, "doStateMachine",
RETURN_FAILED, printout);
#endif