fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

action helper nullptr check #454

Closed
muellerr wants to merge 2 commits from mueller/action-printout into mueller/restructuring
pull from: mueller/action-printout
merge into: fsfw:mueller/restructuring
Conversation 2 Commits 2 Files Changed 1 +13 -1
muellerr commented 2021-08-06 11:17:13 +02:00
Owner
Copy Link

Target is #445 for easier comparison now, might be retargeted.

Target is #445 for easier comparison now, might be retargeted.
muellerr added 1 commit 2021-08-06 11:17:14 +02:00
action helper nullptr check 5a34b684b2
muellerr added the
feature
 label 2021-08-06 11:19:54 +02:00
muellerr added this to the v2.0.0 milestone 2021-08-06 11:21:38 +02:00
mohr commented 2021-08-09 12:44:43 +02:00
Owner
Copy Link

Initialize has checked that the pointer is valid before (as is the main purpose of initialize(), checking the settings).

While I agree that forgetting to call initialize() is an annoying and hard to find bug, I am not sure we should enforce it by doing redundant checks throughout the code.

Initialize has checked that the pointer is valid before (as is the main purpose of `initialize()`, checking the settings). While I agree that forgetting to call `initialize()` is an annoying and hard to find bug, I am not sure we should enforce it by doing redundant checks throughout the code.
muellerr commented 2021-08-09 14:18:51 +02:00
Author
Owner
Copy Link

I think this was forgotten because it was overriden in the ExtendedControllerBase .. nullptr checks are cheap, so I introduced this because the software crashed without any warning.. but I'm not sure whether it is worth it.. It just improved the capability of the FSFW to catch configuration errors

I think this was forgotten because it was overriden in the `ExtendedControllerBase` .. `nullptr` checks are cheap, so I introduced this because the software crashed without any warning.. but I'm not sure whether it is worth it.. It just improved the capability of the FSFW to catch configuration errors
muellerr added 1 commit 2021-08-09 15:29:04 +02:00
Merge branch 'mueller/restructuring' into mueller/action-printout 68489a62d5
mohr closed this pull request 2021-08-09 15:29:09 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
feature
Milestone
No items
No Milestone v2.0.0
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#454
No description provided.
Delete Branch "mueller/action-printout"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?