Linux HAL updates #456

Merged
mohr merged 4 commits from mueller/hal-linux-spi-uart-update into mueller/restructuring 2021-08-09 15:39:19 +02:00
Owner
No description provided.
1. The type correction was merged as part of https://egit.irs.uni-stuttgart.de/eive/fsfw/pulls/7 in the EIVE project. Quotation of PR > definition of getSpiParameters is `void getSpiParameters(spi::SpiModes& spiMode, uint32_t& spiSpeed, UncommonParameters* parameters = nullptr) const;`. > Here, size_t spiSpeed is passed, which implicitely gets converted to a temporary, which can not be bound to uint32_t& and, at least in gcc 9.3.0, leads to a compiler error. 2. Allow flushing the UART buffers. This code was provided by @Jakob.Meier
muellerr added 1 commit 2021-08-06 11:27:41 +02:00
1. The type correction was merged as part of
   eive/fsfw#7 in the
   EIVE project. Quotation of PR

definition of getSpiParameters is `void getSpiParameters(spi::SpiModes& spiMode, uint32_t& spiSpeed, UncommonParameters* parameters = nullptr) const;`.

Here, size_t spiSpeed is passed, which implicitely gets converted to a temporary, which can not be bound to uint32_t& and, at least in gcc 9.3.0, leads to a compiler error.

2. Allow flushing the UART buffers
muellerr added the
bug
feature
labels 2021-08-06 11:28:14 +02:00
muellerr added this to the v2.0.0 milestone 2021-08-06 11:34:13 +02:00
Owner

I prefer having bugfixes and enhancements separated.

I prefer having bugfixes and enhancements separated.
mohr approved these changes 2021-08-09 13:16:19 +02:00
Dismissed
muellerr added 1 commit 2021-08-09 15:31:59 +02:00
mohr dismissed mohr’s review 2021-08-09 15:33:12 +02:00
mohr approved these changes 2021-08-09 15:33:44 +02:00
Dismissed
@ -446,0 +452,4 @@
return NULLPOINTER;
}
deviceFile = uartCookie->getDeviceFile();
uartDeviceMapIter = uartDeviceMap.find(deviceFile);
Owner

please check if the deviceFile actually was found

please check if the deviceFile actually was found
mohr marked this conversation as resolved
mohr dismissed mohr’s review 2021-08-09 15:33:49 +02:00
muellerr added 2 commits 2021-08-09 15:38:11 +02:00
mohr approved these changes 2021-08-09 15:39:12 +02:00
mohr merged commit 1fa59c5cae into mueller/restructuring 2021-08-09 15:39:19 +02:00
muellerr deleted branch mueller/hal-linux-spi-uart-update 2021-09-15 17:19:49 +02:00
Sign in to join this conversation.
No description provided.