fsfw/fsfw
12
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

printout fixes for UnixFileGuard #468

Merged
muellerr merged 5 commits from eive/fsfw:mueller/unix-file-guard-fix into development 2021-09-13 15:10:00 +02:00
Conversation 2 Commits 5 Files Changed 2
+12 -8
muellerr commented 2021-08-18 11:29:43 +02:00
Owner
Copy Link
Copy Source
  • Missing includes
  • Printout format improved
- Missing includes - Printout format improved
muellerr added 1 commit 2021-08-18 11:29:43 +02:00
printout fixes for UnixFileGuard 845c00044e
muellerr added the bug label 2021-08-18 11:29:52 +02:00
muellerr requested review from meierj 2021-08-18 11:30:37 +02:00
muellerr added this to the v2.0.0 milestone 2021-08-18 11:31:08 +02:00
gaisser reviewed 2021-08-19 17:01:23 +02:00
hal/src/fsfw_hal/linux/UnixFileGuard.cpp Outdated
@@ -16,3 +20,2 @@
#else
sif::printError("%sOpening device failed with error code %d.\n", diagnosticPrefix);
sif::printWarning("Error description: %s\n", strerror(errno));
sif::printWarning("%sOpening device failed with error code %d: %s\n",
gaisser commented 2021-08-19 17:01:23 +02:00
Owner
Copy Link
Copy Source

Shouldn't there be a space between diagnosticPrefix and "Opening..." ?

Shouldn't there be a space between diagnosticPrefix and "Opening..." ?
muellerr commented 2021-08-19 17:03:09 +02:00
Author
Owner
Copy Link
Copy Source

Maybe this and a colon would be more clean. Then it needs to be adapted for the ostream implementation as well and some calling code needs to be adapted

Maybe this and a colon would be more clean. Then it needs to be adapted for the ostream implementation as well and some calling code needs to be adapted
muellerr marked this conversation as resolved
muellerr added 1 commit 2021-08-19 17:08:52 +02:00
format adapted b6aebb3061
gaisser approved these changes 2021-08-19 17:13:04 +02:00
muellerr added 1 commit 2021-08-19 17:17:34 +02:00
small tweak 98e3ed897c
muellerr added 1 commit 2021-09-13 14:54:10 +02:00
Merge branch 'development' into mueller/unix-file-guard-fix 0e0989db95
muellerr added 1 commit 2021-09-13 15:08:23 +02:00
Merge branch 'development' into mueller/unix-file-guard-fix 2837d6e0dd
muellerr merged commit b3e0eeb14e into development 2021-09-13 15:10:00 +02:00
muellerr deleted branch mueller/unix-file-guard-fix 2021-09-13 15:10:04 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
meierj
gaisser
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
 Breaking API Change
Changes the API in a non backwards compatible way
 bug
Something is not working
 build
Issues related to the buildsystem, including CI
 cosmetics
Small change most users won't notice
 Documentation
Improvement of code documentation
 duplicate
This issue or pull request already exists
 feature
New feature
 help wanted
Need some help
 hotfix
Quick or important fix that is merged directly into master, causing a new revision
 invalid
#worksforme
 question
More information is needed
 Refactor
Contains a refactoring of some code
 Tests
Issues related to testing code
 wontfix
This won't be fixed
No Label bug
Milestone
No items
No Milestone v2.0.0
Assignees
Clear assignees
ahinkel (Andy Hinkel) gaisser (Steffen Gaisser) jenkins_buildfix meierj (Jakob Meier) mohr (Ulrich Mohr) mspahr muellerr (Robin Müller) tbaumgartl (Tobias Baumgartl)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#468
Delete Branch "eive/fsfw:mueller/unix-file-guard-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?