fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

printout fixes for UnixFileGuard #468

Merged
muellerr merged 5 commits from eive/fsfw:mueller/unix-file-guard-fix into development 2021-09-13 15:10:00 +02:00
Conversation 0 Commits 5 Files Changed 2 +12 -8
muellerr commented 2021-08-18 11:29:43 +02:00
Owner
Copy Link
  • Missing includes
  • Printout format improved
- Missing includes - Printout format improved
muellerr added 1 commit 2021-08-18 11:29:43 +02:00
muellerr added the
bug
 label 2021-08-18 11:29:52 +02:00
muellerr requested review from meierj 2021-08-18 11:30:37 +02:00
muellerr added this to the v2.0.0 milestone 2021-08-18 11:31:08 +02:00
gaisser reviewed 2021-08-19 17:01:23 +02:00
hal/src/fsfw_hal/linux/UnixFileGuard.cpp Outdated
@ -16,3 +20,2 @@
#else
sif::printError("%sOpening device failed with error code %d.\n", diagnosticPrefix);
sif::printWarning("Error description: %s\n", strerror(errno));
sif::printWarning("%sOpening device failed with error code %d: %s\n",
gaisser commented 2021-08-19 17:01:23 +02:00
Owner
Copy Link

Shouldn't there be a space between diagnosticPrefix and "Opening..." ?

Shouldn't there be a space between diagnosticPrefix and "Opening..." ?
muellerr commented 2021-08-19 17:03:09 +02:00
Author
Owner
Copy Link

Maybe this and a colon would be more clean. Then it needs to be adapted for the ostream implementation as well and some calling code needs to be adapted

Maybe this and a colon would be more clean. Then it needs to be adapted for the ostream implementation as well and some calling code needs to be adapted
muellerr marked this conversation as resolved
muellerr added 1 commit 2021-08-19 17:08:52 +02:00
gaisser approved these changes 2021-08-19 17:13:04 +02:00
muellerr added 1 commit 2021-08-19 17:17:34 +02:00
muellerr added 1 commit 2021-09-13 14:54:10 +02:00
muellerr added 1 commit 2021-09-13 15:08:23 +02:00
muellerr merged commit b3e0eeb14e into development 2021-09-13 15:10:00 +02:00
muellerr deleted branch mueller/unix-file-guard-fix 2021-09-13 15:10:04 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
meierj
gaisser
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v2.0.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#468
No description provided.
Delete Branch "eive/fsfw:mueller/unix-file-guard-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?