UART bugfixes and improvements #471

muellerr · 2021-09-08T16:11:53+02:00

muellerr commented

2021-09-08 16:11:53 +02:00

Set non-blocking flag, but only for canonical mode. In non-canonical mode, VTIME and VMIN determine timing behaviour and O_NONBLOCK would override this. This PR has the bug label because a non-talking device can shut down the PST in canonical mode (this bug was found testing a GPS device)
Check sendLen before checking data pointer to avoid warning
use sif::warning instead of sif::debug
Use FSFW_VERBOSE_LEVEL instead of OBSW_VERBOSE_LEVEL

1. Set non-blocking flag, but only for canonical mode. In non-canonical mode, `VTIME` and `VMIN` determine timing behaviour and O_NONBLOCK would override this. This PR has the bug label because a non-talking device can shut down the PST in canonical mode (this bug was found testing a GPS device) 2. Check `sendLen` before checking data pointer to avoid warning 3. use `sif::warning` instead of `sif::debug` 4. Use `FSFW_VERBOSE_LEVEL` instead of `OBSW_VERBOSE_LEVEL`

muellerr added 1 commit 2021-09-08 16:11:54 +02:00

c42eb59d2e

UART bugfixes and improvements

muellerr added the

bug

label 2021-09-08 16:11:59 +02:00

muellerr added this to the v2.0.0 milestone 2021-09-08 16:12:05 +02:00

muellerr requested review from meierj 2021-09-08 16:12:21 +02:00

meierj approved these changes 2021-09-08 17:19:07 +02:00

meierj merged commit 38afa494ce into development

2021-09-08 17:19:30 +02:00

meierj referenced this issue from a commit