fsfw/fsfw
fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

UART bugfixes and improvements #471

Merged
meierj merged 1 commits from eive/fsfw:mueller/uart-improvements into development 2021-09-08 17:19:30 +02:00
Conversation 1 Commits 1 Files Changed 2 +33 -13
muellerr commented 2021-09-08 16:11:53 +02:00
Owner
Copy Link
  1. Set non-blocking flag, but only for canonical mode. In non-canonical mode, VTIME and VMIN determine timing behaviour and O_NONBLOCK would override this. This PR has the bug label because a non-talking device can shut down the PST in canonical mode (this bug was found testing a GPS device)
  2. Check sendLen before checking data pointer to avoid warning
  3. use sif::warning instead of sif::debug
  4. Use FSFW_VERBOSE_LEVEL instead of OBSW_VERBOSE_LEVEL
1. Set non-blocking flag, but only for canonical mode. In non-canonical mode, `VTIME` and `VMIN` determine timing behaviour and O_NONBLOCK would override this. This PR has the bug label because a non-talking device can shut down the PST in canonical mode (this bug was found testing a GPS device) 2. Check `sendLen` before checking data pointer to avoid warning 3. use `sif::warning` instead of `sif::debug` 4. Use `FSFW_VERBOSE_LEVEL` instead of `OBSW_VERBOSE_LEVEL`
muellerr added 1 commit 2021-09-08 16:11:54 +02:00
muellerr added the
bug
 label 2021-09-08 16:11:59 +02:00
muellerr added this to the v2.0.0 milestone 2021-09-08 16:12:05 +02:00
muellerr requested review from meierj 2021-09-08 16:12:21 +02:00
meierj approved these changes 2021-09-08 17:19:07 +02:00
meierj merged commit 38afa494ce into development 2021-09-08 17:19:30 +02:00
meierj deleted branch mueller/uart-improvements 2021-09-08 17:19:40 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
meierj
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
bug
Milestone
No items
No Milestone v2.0.0
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#471
No description provided.
Delete Branch "eive/fsfw:mueller/uart-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?