fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Devicehandler Package #481

Merged
meierj merged 4 commits from eive/fsfw:mueller/devicehandler-package into development 2021-09-25 16:49:54 +02:00
Conversation 3 Commits 4 Files Changed 6 +373 -14
muellerr commented 2021-09-23 18:15:53 +02:00
Owner
Copy Link
  • Added missing code for LIS3MDL MGM, RM3100 MGM and L3GD20 Gyro
  • Added way to specify limits for these devices
- Added missing code for LIS3MDL MGM, RM3100 MGM and L3GD20 Gyro - Added way to specify limits for these devices
muellerr added 2 commits 2021-09-23 18:15:55 +02:00
Device handler updates f2bc374f0f
added missing defines for debug output a6bd7c0d6e
muellerr requested review from meierj 2021-09-23 18:17:36 +02:00
muellerr added the bug label 2021-09-23 18:17:45 +02:00
muellerr removed the bug label 2021-09-24 00:21:09 +02:00
meierj reviewed 2021-09-24 11:57:22 +02:00
hal/src/fsfw_hal/devicehandlers/devicedefinitions/MgmLIS3HandlerDefs.h Outdated
@@ -0,0 +154,4 @@
TEMPERATURE_CELCIUS
};
class MgmPrimaryDataset: public StaticLocalDataSet<5> {
meierj commented 2021-09-24 11:57:22 +02:00
Owner
Copy Link

This set has only 4 entries so I think also NUM_VARIABLES should be 4

This set has only 4 entries so I think also NUM_VARIABLES should be 4
muellerr marked this conversation as resolved
meierj reviewed 2021-09-24 11:58:32 +02:00
hal/src/fsfw_hal/devicehandlers/devicedefinitions/MgmRM3100HandlerDefs.h Outdated
@@ -0,0 +108,4 @@
FIELD_STRENGTH_Z,
};
class Rm3100PrimaryDataset: public StaticLocalDataSet<3 * sizeof(float)> {
meierj commented 2021-09-24 11:58:32 +02:00
Owner
Copy Link
  • only three entries in dataset (not 3 * sizeof(float))
* only three entries in dataset (not 3 * sizeof(float))
muellerr marked this conversation as resolved
meierj added 1 commit 2021-09-24 12:19:23 +02:00
removed unused variable switchId from GyroL3GD20Handler class f6b03dee6a
muellerr added 1 commit 2021-09-25 16:40:31 +02:00
fix dataset sizes a37b6184fc
meierj approved these changes 2021-09-25 16:49:39 +02:00
meierj merged commit 061d79bb62 into development 2021-09-25 16:49:54 +02:00
muellerr added this to the v2.0.0 milestone 2021-09-27 15:02:10 +02:00
mohr deleted branch mueller/devicehandler-package 2021-09-27 15:27:45 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
meierj
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
 Breaking API Change
Changes the API in a non backwards compatible way
 bug
Something is not working
 build
Issues related to the buildsystem, including CI
 cosmetics
Small change most users won't notice
 Documentation
Improvement of code documentation
 duplicate
This issue or pull request already exists
 feature
New feature
 help wanted
Need some help
 hotfix
Quick or important fix that is merged directly into master, causing a new revision
 invalid
#worksforme
 question
More information is needed
 Refactor
Contains a refactoring of some code
 Tests
Issues related to testing code
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone v2.0.0
Assignees
Clear assignees
ahinkel gaisser jenkins_buildfix meierj mohr muellerr tbaumgartl
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#481
Delete Branch "eive/fsfw:mueller/devicehandler-package"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?