fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

Devicehandler Package #481

Merged
meierj merged 4 commits from eive/fsfw:mueller/devicehandler-package into development 2021-09-25 16:49:54 +02:00
Conversation 0 Commits 4 Files Changed 6 +2 -2
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a37b6184fc - Show all commits

2
hal/src/fsfw_hal/devicehandlers/devicedefinitions/MgmLIS3HandlerDefs.h
View File

@ -154,7 +154,7 @@ enum MgmPoolIds: lp_id_t {
TEMPERATURE_CELCIUS
};
class MgmPrimaryDataset: public StaticLocalDataSet<5> {
class MgmPrimaryDataset: public StaticLocalDataSet<4> {
muellerr marked this conversation as resolved Outdated
meierj commented 2021-09-24 11:57:22 +02:00
Outdated
Review
Copy Link

This set has only 4 entries so I think also NUM_VARIABLES should be 4

This set has only 4 entries so I think also NUM_VARIABLES should be 4
public:
MgmPrimaryDataset(HasLocalDataPoolIF* hkOwner):
StaticLocalDataSet(hkOwner, MGM_DATA_SET_ID) {}

2
hal/src/fsfw_hal/devicehandlers/devicedefinitions/MgmRM3100HandlerDefs.h
View File

@ -108,7 +108,7 @@ enum MgmPoolIds: lp_id_t {
FIELD_STRENGTH_Z,
};
class Rm3100PrimaryDataset: public StaticLocalDataSet<3 * sizeof(float)> {
class Rm3100PrimaryDataset: public StaticLocalDataSet<3> {
muellerr marked this conversation as resolved Outdated
meierj commented 2021-09-24 11:58:32 +02:00
Outdated
Review
Copy Link
  • only three entries in dataset (not 3 * sizeof(float))
* only three entries in dataset (not 3 * sizeof(float))
public:
Rm3100PrimaryDataset(HasLocalDataPoolIF* hkOwner):
StaticLocalDataSet(hkOwner, MGM_DATASET_ID) {}