fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

missing preproc define #497

Closed
muellerr wants to merge 2 commits from KSat:mueller/event-manager-tweak into development
pull from: KSat:mueller/event-manager-tweak
merge into: fsfw:development
Conversation 3 Commits 2 Files Changed 1 +4
muellerr commented 2021-10-07 10:36:40 +02:00
Owner
Copy Link

Only include printUtility if printing of Events is enabled

Only include `printUtility` if printing of Events is enabled
muellerr added 1 commit 2021-10-07 10:36:40 +02:00
muellerr added this to the v2.0.1 milestone 2021-10-07 10:36:47 +02:00
muellerr added the
bug
 label 2021-10-07 10:37:00 +02:00
mohr commented 2021-10-08 13:03:39 +02:00
Owner
Copy Link

Isn't this redundant to the #if in l.130 (as seen by a duplicate #endif at the end)?

Isn't this redundant to the #if in l.130 (as seen by a duplicate #endif at the end)?
👍 1
muellerr commented 2021-10-09 13:35:50 +02:00
Author
Owner
Copy Link

Hmm that is weird, it definitely looks like this. I definitely received a compile error that this function was declared but not defined in the header though.. I'll look into it in the next time

Hmm that is weird, it definitely looks like this. I definitely received a compile error that this function was declared but not defined in the header though.. I'll look into it in the next time
gaisser added 1 commit 2021-10-11 15:19:48 +02:00
muellerr commented 2021-10-11 15:30:26 +02:00
Author
Owner
Copy Link

Closed, this was probably false-positive error from the IDE

Closed, this was probably false-positive error from the IDE
muellerr closed this pull request 2021-10-11 15:30:27 +02:00
muellerr removed this from the v2.0.1 milestone 2021-10-11 18:02:39 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#497
No description provided.
Delete Branch "KSat:mueller/event-manager-tweak"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?